New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cobra to 1.3.0 for kubectl, fixes flag value parsing issue when value contains colon #107436
Conversation
… don't work when the kubectl command uses the --context flag to specify a context that contains a colon
@brianpursley: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianpursley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold for review... |
@brianpursley: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
OK, it seems I may need to update cobra across k/k for this. Let me reconsider. I'll close this PR for now. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Upgrade Cobra from 1.2.1 to 1.3.0 to fix a bug where bash completions don't work when the kubectl command uses the
--context
flag to specify a context that contains a colon.Example:
Additionally...
The
GenBashCompletionV2()
function that is now being used allows for descriptions to be shown for bash completion commands, which I enabled. This is similar to what kubectl does for zsh and fish completions.Example:
Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#1157
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: