New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix klog lock release on panic #106535
Fix klog lock release on panic #106535
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: astraw99 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@astraw99: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
please fix in https://github.com/kubernetes/klog/ first |
/close |
/triage accepted |
Got it, new PR: kubernetes/klog#272 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When provided the klog.SetLogger(selfLogger), but with the Error func return a panic, will lead to controller
WaitForNamedCacheSync
never returned.This PR captured the panic and release the lock instantly.
Which issue(s) this PR fixes:
Fixes #106534
Special notes for your reviewer:
Also fixed a blank typo, to make it clean when retrieving the log data with json or other formats.
Does this PR introduce a user-facing change?