New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #106163: kube-proxy: fix stale detection logic #106239
Automated cherry pick of #106163: kube-proxy: fix stale detection logic #106239
Conversation
The logic to detect stale endpoints was not assuming the endpoint readiness. We can have stale entries on UDP services for 2 reasons: - an endpoint was receiving traffic and is removed or replaced - a service was receiving traffic but not forwarding it, and starts to forward it. Add an e2e test to cover the regression
@aojea: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @thockin @danwinship |
/kind bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ping @kubernetes/release-managers |
@aojea can this fix be backported to 1.21? |
the user reporting it says it doesn't hit this bug in 1.21, I prefer to be cautious and do it only for 1.22, this is caused by a complex confluence of new features and feature gates ... |
Sounds good, thank you @aojea ! |
Cherry pick of #106163 on release-1.22.
#106163: kube-proxy: fix stale detection logic
For details on the cherry pick process, see the cherry pick requests page.