Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate JobTrackingWithFinalizers to beta #105687

Merged
merged 1 commit into from Oct 19, 2021
Merged

Graduate JobTrackingWithFinalizers to beta #105687

merged 1 commit into from Oct 19, 2021

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Oct 14, 2021 •
edited

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Graduate JobTrackingWithFinalizers to beta and enable feature by default.

Also Update integration tests for other features to assume that finalizers are present.

Which issue(s) this PR fixes:

Ref kubernetes/enhancements#2307

Special notes for your reviewer:

The implementation requirements were satisfied by #105197

Upgrade->downgrade->upgrade manual test was performed kubernetes/enhancements#3011

Does this PR introduce a user-facing change?

JobTrackingWithFinalizers graduates to beta. Feature is enabled by default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/2307-job-tracking-without-lingering-pods
- [Usage]: https://kubernetes.io/docs/concepts/workloads/controllers/job/#job-tracking-with-finalizers

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 14, 2021
@alculquicondor
Copy link
Member Author

/label api-review

/assign @soltysh

@k8s-ci-robot k8s-ci-robot added api-review Categorizes an issue or PR as actively needing an API review. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Oct 14, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 14, 2021
@alculquicondor
Copy link
Member Author

/hold
The failures are relevant.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2021
@alculquicondor
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 14, 2021
@alculquicondor
Graduate JobTrackingWithFinalizers to beta
2c1b3fd 
Enable feature by default.

Update integration tests for other features to assume that finalizers are present.

Change-Id: Ie969344f572627dba882c0e862e5700dadaf3026
@liggitt
Copy link
Member

liggitt commented Oct 19, 2021

API bits lgtm, routing to @soltysh for apps review

@liggitt liggitt self-assigned this Oct 19, 2021
@liggitt liggitt added this to the v1.23 milestone Oct 19, 2021
@liggitt liggitt added this to API review completed, 1.23 in API Reviews Oct 19, 2021
@liggitt
Copy link
Member

liggitt commented Oct 19, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021
soltysh
soltysh approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@soltysh
Copy link
Contributor

soltysh commented Oct 19, 2021

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c733594 into kubernetes:master Oct 19, 2021
@alculquicondor alculquicondor mentioned this pull request Nov 9, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@soltysh soltysh

@liggitt liggitt

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.23
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alculquicondor @liggitt @soltysh @k8s-ci-robot