ignore register already exist error for metrics

[pacoxu]

/kind bug

xref #104940

The problem is similar to prometheus/client_golang#716 (comment).

I tried to fix 104940 by ignoring AlreadyRegisteredError in the implementation of MustRegister. (I am inspired by https://github.com/weaveworks/promrus/pull/9/files)

kubernetes/vendor/github.com/prometheus/client_golang/prometheus/registry.go

Lines 400 to 406 in 005dfcd

	func (r *Registry) MustRegister(cs ...Collector) {
	for _, c := range cs {
	if err := r.Register(c); err != nil {
	panic(err)
	}
	}
	}

None

[k8s-ci-robot]

@pacoxu: The label(s) sig/instrumention cannot be applied, because the repository doesn't have them.

In response to this:

/kind bug

xref #104940

The problem is similar to prometheus/client_golang#716 (comment).

I tried to fix 104940 by ignore AlreadyRegisteredError in the implementation of MustRegister.
/sig instrumention

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@pacoxu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pacoxu
To complete the pull request process, please assign brancz after the PR has been reviewed.
You can assign the PR to them by writing /assign @brancz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• staging/src/k8s.io/component-base/metrics/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pacoxu]

/sig instrumentation

A simple way to reproduce it using GOFLAGS=-count=10 to run the TestSample case.

 make test KUBE_RACE=-race KUBE_TIMEOUT=--timeout=600s GOFLAGS=-count=10 WHAT=./vendor/k8s.io/apiserver/pkg/util/flowcontrol/metrics/

[pacoxu]

/assign @dashpole @ehashman

[k8s-ci-robot]

@pacoxu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-unit	64a507b	link	true	/test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fedebongio]

/remove-sig api-machinery

[dashpole]

Is this ready for review?

[pacoxu]

Is this ready for review?

This can fix the dup registed error, but it can not fix the failure with “-count=10”(the metrics can not be reset during the unit test)

[pacoxu]

See #105809