Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop dead beta storage and validation code #104248

Merged
merged 8 commits into from Aug 10, 2021
Merged

Drop dead beta storage and validation code #104248

merged 8 commits into from Aug 10, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 9, 2021 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Drops the storage and validation code that was only exercised by the beta versions no longer served since 1.22.

Does this PR introduce a user-facing change?

kube-apiserver: The `rbac.authorization.k8s.io/v1alpha1` API version is removed; use the `rbac.authorization.k8s.io/v1` API, available since v1.8. The `scheduling.k8s.io/v1alpha1` API version is removed; use the `scheduling.k8s.io/v1` API, available since v1.14.

/assign @deads2k

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 9, 2021
@liggitt
Copy link
Member Author

liggitt commented Aug 9, 2021

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 9, 2021
@liggitt
Copy link
Member Author

liggitt commented Aug 9, 2021

/hold for reviews

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2021
@liggitt
Copy link
Member Author

liggitt commented Aug 9, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 9, 2021
@deads2k
Copy link
Contributor

deads2k commented Aug 10, 2021

Now that's a cathartic PR.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2021
@liggitt
Copy link
Member Author

liggitt commented Aug 10, 2021

/assign @robscott
PTAL at the Drop legacy validation logic for networking API commit

/assign @msau42
PTAL at the Drop legacy status logic for volumeattachments API commit

@robscott
Copy link
Member

This is great, thanks @liggitt! Networking commit LGTM.

@msau42
Copy link
Member

msau42 commented Aug 10, 2021

/lgtm
for volumeattachment validation

@liggitt
Copy link
Member Author

liggitt commented Aug 10, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2021
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot merged commit 48da959 into kubernetes:master Aug 10, 2021
@liggitt liggitt deleted the drop-beta branch August 11, 2021 02:35
@tengqm
Copy link
Contributor

tengqm commented Aug 16, 2021

Why https://github.com/kubernetes/kubernetes/tree/master/pkg/apis/rbac/v1alpha1 is still there and https://github.com/kubernetes/kubernetes/tree/master/pkg/apis/scheduling/v1alpha1 is still there if both APIs are dropped?

@liggitt
Copy link
Member Author

liggitt commented Aug 16, 2021

All code related to serving those versions was removed, but the types and conversions still exist to support reading/converting data stored in etcd in those versions

@tengqm
Copy link
Contributor

tengqm commented Aug 16, 2021

So ... those schemes are still installed, just for conversions convenience?

@liggitt
Copy link
Member Author

liggitt commented Aug 16, 2021

they're installed so that pre-release data exists in etcd, it can still be read/converted in order to be served as v1 objects in response to a v1 API request

@tengqm
Copy link
Contributor

tengqm commented Aug 16, 2021

@liggitt Thanks for the clarification.

@pacoxu pacoxu mentioned this pull request Oct 31, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@robscott robscott

@deads2k deads2k

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@liggitt @k8s-ci-robot @deads2k @robscott @msau42 @k8s-triage-robot @tengqm