Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Add wzshiming as SIG Node reviewer #104143

Merged
merged 1 commit into from Jan 6, 2022
Merged

Request: Add wzshiming as SIG Node reviewer #104143

merged 1 commit into from Jan 6, 2022

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Aug 5, 2021 •
edited by dchen1107

What type of PR is this?
/kind cleanup
/sig node

What this PR does / why we need it:
Requesting SIG Node reviewer status.

Special notes for your reviewer:
Completed reviewer requirements

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/cc @Random-Liu @dchen1107 @derekwaynecarr @yujuhong @sjenning @mrunalp @klueska

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 5, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Aug 5, 2021
@pacoxu
Copy link
Member

pacoxu commented Sep 2, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 2, 2021
@pacoxu pacoxu moved this from Triage to Needs Approver in SIG Node PR Triage Sep 2, 2021
@aojea
Copy link
Member

aojea commented Oct 21, 2021

+1

@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2021
@dchen1107
Copy link
Member

cc/ @ehashman @SergeyKanzhelev

@SergeyKanzhelev
Copy link
Member

/lgtm

+1, thank you for all the work!

@bobbypage
Copy link
Member

/lgtm

+1 big thanks for all your efforts in SIG Node and and especially with graceful node shutdown!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2021
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 16, 2021
SergeyKanzhelev
SergeyKanzhelev approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

(reapplying)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2021
@dims
Copy link
Member

dims commented Jan 6, 2022

/assign @liggitt @smarterclayton

(need root OWNERS approval)

@liggitt
Copy link
Member

liggitt commented Jan 6, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, SergeyKanzhelev, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5fbb080 into kubernetes:master Jan 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 6, 2022
@ehashman
Copy link
Member

ehashman commented Jan 6, 2022

Congrats!

@wzshiming wzshiming deleted the wzshiming-node-reviewer branch January 7, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@klueska klueska Awaiting requested review from klueska

@mrunalp mrunalp Awaiting requested review from mrunalp

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@sjenning sjenning Awaiting requested review from sjenning

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@bobbypage bobbypage

@liggitt liggitt

@smarterclayton smarterclayton

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Needs Approver
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet