Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][1.20][go1.15] Update to go1.15.14 #103678

Closed
wants to merge 3 commits into from
Closed

[WIP][1.20][go1.15] Update to go1.15.14 #103678

wants to merge 3 commits into from

Conversation

mengjiao-liu
Copy link
Member

@mengjiao-liu mengjiao-liu commented Jul 14, 2021 •
edited

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Update to Go 1.15.14

Tracking issue: kubernetes/release#2157
Slack thread: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1623076353251200

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built using Go 1.15.14

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Wait kubernetes/repo-infra new tag kubernetes/repo-infra#242
/hold

@k8s-ci-robot
Copy link
Contributor

@mengjiao-liu: This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review.

(For details on the patch release process and schedule, see the Patch Releases page.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Jul 14, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 14, 2021
@k8s-ci-robot
Copy link
Contributor

@mengjiao-liu: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@mengjiao-liu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 14, 2021
@mengjiao-liu mengjiao-liu changed the title [1.20][go1.15] Update to go1.15.14 [WIP][1.20][go1.15] Update to go1.15.14 Jul 14, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mengjiao-liu
To complete the pull request process, please assign cblecker, dashpole, sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @cblecker @dashpole @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 14, 2021
@k8s-ci-robot k8s-ci-robot requested a review from listx July 14, 2021 04:05
@k8s-ci-robot
Copy link
Contributor

@mengjiao-liu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd 814103a link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-node-e2e 814103a link /test pull-kubernetes-node-e2e
pull-kubernetes-e2e-kind 814103a link /test pull-kubernetes-e2e-kind
pull-publishing-bot-validate 814103a link /test pull-publishing-bot-validate
pull-kubernetes-dependencies 814103a link /test pull-kubernetes-dependencies
pull-kubernetes-bazel-build 814103a link /test pull-kubernetes-bazel-build
pull-kubernetes-e2e-gce-100-performance 814103a link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-typecheck 814103a link /test pull-kubernetes-typecheck
pull-kubernetes-bazel-test 814103a link /test pull-kubernetes-bazel-test
pull-kubernetes-integration 814103a link /test pull-kubernetes-integration
pull-kubernetes-verify 814103a link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mengjiao-liu
Copy link
Member Author

PR #103677 does the same thing.
/close

@k8s-ci-robot
Copy link
Contributor

@mengjiao-liu: Closed this PR.

In response to this:

PR #103677 does the same thing.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@puerco
Copy link
Member

puerco commented Jul 15, 2021

Hey @mengjiao-liu I just noticed we sent the same PR almost at the same time, sorry about that.
Next time let me know and we can work on yours. Sorry!

@mengjiao-liu
Copy link
Member Author

It’s okay, don’t be sorry for this, thank you for your contribution too!😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan Awaiting requested review from hasheddan

@listx listx Awaiting requested review from listx

Assignees
No one assigned
Labels
area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mengjiao-liu @k8s-ci-robot @puerco