Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for Prober TerminationGracePeriodSeconds #103245

Merged
merged 5 commits into from Jul 13, 2021
Merged

Add validation for Prober TerminationGracePeriodSeconds #103245

merged 5 commits into from Jul 13, 2021

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Jun 28, 2021 •
edited

What type of PR is this?

/kind feature
/sig node

What this PR does / why we need it:

Which issue(s) this PR fixes:

ref #98866 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

ACTION REQUIRED:  if someone had the ProbeTerminationGracePeriod alpha feature enabled in 1.21, they should update/delete any workloads/pods with probe terminationGracePeriods < 1 before upgrading

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 28, 2021
@wzshiming
Copy link
Member Author

/cc @ehashman @liggitt

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Jun 28, 2021
@wzshiming wzshiming mentioned this pull request Jun 28, 2021
Merged
@wzshiming
Copy link
Member Author

/retest

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 28, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2021
@wzshiming wzshiming changed the title Add validation and default values for Prober TerminationGracePeriodSeconds Add validation for Prober TerminationGracePeriodSeconds Jun 28, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Jun 28, 2021
@ehashman
Copy link
Member

/assign
/priority important-soon
/triage accepted

@wzshiming wzshiming requested a review from wangyysde July 7, 2021 02:52
@wzshiming wzshiming moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Jul 7, 2021
ehashman
ehashman reviewed Jul 7, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
a few nits but nothing blocking

/assign @liggitt
for approval

pkg/apis/core/validation/validation_test.go Show resolved Hide resolved
pkg/apis/core/validation/validation_test.go Show resolved Hide resolved
pkg/apis/core/validation/validation.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
@liggitt
Copy link
Member

liggitt commented Jul 8, 2021

requiring >= 1 when non-nil looks good, drop the feature gate check inside validation.go and add the release note

@ehashman
Copy link
Member

ehashman commented Jul 8, 2021

Requested exception: https://groups.google.com/g/kubernetes-sig-node/c/NrqKjVQJrUE/m/NjNSbQJWAAAJ

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 9, 2021
@liggitt
Copy link
Member

liggitt commented Jul 12, 2021

API validation change lgtm with the accompanying release note for the alpha field.

@liggitt liggitt added this to API review completed, 1.22 in API Reviews Jul 12, 2021
@liggitt liggitt mentioned this pull request Jul 13, 2021
Merged
3 tasks
@liggitt
Copy link
Member

liggitt commented Jul 13, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2021
@JamesLaverack
Copy link
Member

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 13, 2021
@liggitt
Copy link
Member

liggitt commented Jul 13, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2021
@ehashman
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit e375563 into kubernetes:master Jul 13, 2021
SIG Node PR Triage automation moved this from Needs Approver to Done Jul 13, 2021
@wzshiming wzshiming deleted the fix/prober-termination branch July 14, 2021 01:43
@kebe7jun kebe7jun mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@ehashman ehashman ehashman left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@vishh vishh Awaiting requested review from vishh

@wangyysde wangyysde Awaiting requested review from wangyysde

Assignees

@liggitt liggitt

@ehashman ehashman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.22
SIG Node PR Triage
Done
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wzshiming @fejta-bot @ehashman @liggitt @k8s-ci-robot @JamesLaverack @wangyysde