Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade prometheus/common to v0.28.0 #102913

Merged
merged 6 commits into from Aug 9, 2021
Merged

upgrade prometheus/common to v0.28.0 #102913

merged 6 commits into from Aug 9, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jun 16, 2021 •
edited

What type of PR is this?

/kind cleanup

/cc dims liggitt
for prometheus/common#304

What this PR does / why we need it:

https://github.com/prometheus/common/releases/tag/v0.28.0

#102913 (comment)

  • maxDepthOfDependencies： 33 -> 29
  • totalDependencies: -4. remove below dependencies
    • github.com/alecthomas/units
    • github.com/jpillora/backoff
    • cloud.google.com/go/pubsub
    • cloud.google.com/go/datastore

Which issue(s) this PR fixes:

refer to #102144 closed PR to upgrade prometheus/common
part of #102145 : follow up of unwanted dependencies.

Special notes for your reviewer:

After upgrading Prometheus/common to v0.28.0, some other dependencies need upgrade or can be removed.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 16, 2021
@pacoxu pacoxu force-pushed the upgrade-promotheus-common branch from 2a588b7 to d590574 Compare June 16, 2021 08:45
@pacoxu pacoxu marked this pull request as ready for review June 16, 2021 08:45
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2021
@eddiezane
Copy link
Member

On @liggitt to remove hold.

@pacoxu
Copy link
Member Author

pacoxu commented Aug 5, 2021 •
edited

On @liggitt to remove hold.

The hold is for upgrade prometheus/common to v0.26.0

#102913 (comment)

/hold

maybe in favor of #102561 and #102833 ?

@liggitt
Copy link
Member

liggitt commented Aug 5, 2021

#102913 (comment) is still outstanding, then lgtm

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 6, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Aug 6, 2021 •
edited

#102913 (comment) is still outstanding, then lgtm

Fixed in 52a8ffb.
Sorry to miss that comment. @liggitt @swetharepakula @prameshj would you PTAL again for #102913 (comment)?

@pacoxu
add 'projects/' suffix if this library is used with an older version …
768d69a 
…of the google api library

Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@liggitt
Copy link
Member

liggitt commented Aug 9, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2021
@liggitt
Copy link
Member

liggitt commented Aug 9, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4b4d12f into kubernetes:master Aug 9, 2021
SIG Auth Old automation moved this from Needs Triage to Closed / Done Aug 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 9, 2021
sdmodi added a commit to sdmodi/cloud-provider-gcp that referenced this pull request Aug 9, 2021
@sdmodi
Update google.golang.org/api to v0.46.0
aece17f 
This is the same version that k/k is pointing to after
kubernetes/kubernetes#102913
@sdmodi sdmodi mentioned this pull request Aug 9, 2021
Merged
@pacoxu pacoxu mentioned this pull request Sep 12, 2021
Closed
@pacoxu pacoxu deleted the upgrade-promotheus-common branch May 10, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@swetharepakula swetharepakula swetharepakula left review comments

@basantsa1989 basantsa1989 basantsa1989 left review comments

@dims dims Awaiting requested review from dims

@cheftako cheftako Awaiting requested review from cheftako

@jpbetz jpbetz Awaiting requested review from jpbetz

@eddiezane eddiezane Awaiting requested review from eddiezane

@prameshj prameshj Awaiting requested review from prameshj

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Node PR Triage
Triage
SIG Auth Old
Closed / Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet