Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-place Pod Vertical Scaling feature #102884

Merged
merged 5 commits into from
Feb 28, 2023
Merged

In-place Pod Vertical Scaling feature #102884

merged 5 commits into from
Feb 28, 2023
+10,279 −1,268

Commits on Feb 24, 2023

  1. In-place Pod Vertical Scaling - API changes 

     1. Define ContainerResizePolicy and add it to Container struct.
 2. Add ResourcesAllocated and Resources fields to ContainerStatus struct.
 3. Define ResourcesResizeStatus and add it to PodStatus struct.
 4. Add InPlacePodVerticalScaling feature gate and drop disabled fields.
 5. ResizePolicy validation & defaulting and Resources mutability for CPU/Memory.
 6. Various fixes from code review feedback (originally committed on Apr 12, 2022)
KEP: /enhancements/keps/sig-node/1287-in-place-update-pod-resources
    @vinaykul
    vinaykul committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    76962b0 View commit details
    Browse the repository at this point in the history

  2. Generated files and compat data from API changes

    @vinaykul
    vinaykul committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    3c70be1 View commit details
    Browse the repository at this point in the history

  3. In-place Pod Vertical Scaling - Scheduler changes

    @vinaykul
    vinaykul committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    231849a View commit details
    Browse the repository at this point in the history

  4. In-place Pod Vertical Scaling - core implementation 

    1. Core Kubelet changes to implement In-place Pod Vertical Scaling.
2. E2E tests for In-place Pod Vertical Scaling.
3. Refactor kubelet code and add missing tests (Derek's kubelet review)
4. Add a new hash over container fields without Resources field to allow feature gate toggling without restarting containers not using the feature.
5. Fix corner-case where resize A->B->A gets ignored
6. Add cgroup v2 support to pod resize E2E test.
KEP: /enhancements/keps/sig-node/1287-in-place-update-pod-resources

Co-authored-by: Chen Wang <Chen.Wang1@ibm.com>
    @vinaykul @wangchen615
    vinaykul and wangchen615 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    f2bd94a View commit details
    Browse the repository at this point in the history

  5. This commit contains the following: 

    1. Scheduler bug-fix + scheduler-focussed E2E tests
2. Add cgroup v2 support for in-place pod resize
3. Enable full E2E pod resize test for containerd>=1.6.9 and EventedPLEG related changes.

Co-Authored-By: Vinay Kulkarni <vskibum@gmail.com>
    @wangchen615 @vinaykul
    wangchen615 and vinaykul committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    7db339d View commit details
    Browse the repository at this point in the history