Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: windows: Fix Pods with Projected Volumes #102868

Closed
wants to merge 2 commits into from
Closed

WIP: windows: Fix Pods with Projected Volumes #102868

wants to merge 2 commits into from

Conversation

aravindhp
Copy link
Contributor

@aravindhp aravindhp commented Jun 15, 2021 •
edited

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #102849

Special notes for your reviewer:

Not ready for review yet

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

@aravindhp: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/regression Categorizes issue or PR as related to a regression from a prior release. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 15, 2021
@aravindhp
Copy link
Contributor Author

/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aravindhp
To complete the pull request process, please assign dchen1107 after the PR has been reviewed.
You can assign the PR to them by writing /assign @dchen1107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aravindhp aravindhp force-pushed the windows-fix-projected-volumes branch from 76a5d68 to 589b1d5 Compare June 15, 2021 03:27
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 15, 2021
@jsturtevant
Copy link
Contributor

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 15, 2021
@aravindhp aravindhp force-pushed the windows-fix-projected-volumes branch from 589b1d5 to 5918378 Compare June 16, 2021 21:20
@rphillips rphillips mentioned this pull request Jun 17, 2021
Merged
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 23, 2021
bertinatto pushed a commit to bertinatto/kubernetes that referenced this pull request Feb 27, 2024
@rphillips @bertinatto
UPSTREAM: <carry>: only chown if non-windows machine
ab1a3c5 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
bertinatto pushed a commit to bertinatto/kubernetes that referenced this pull request Feb 28, 2024
@rphillips @bertinatto
UPSTREAM: <carry>: only chown if non-windows machine
f55e013 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
bertinatto pushed a commit to bertinatto/kubernetes that referenced this pull request Mar 1, 2024
@rphillips @bertinatto
UPSTREAM: <carry>: only chown if non-windows machine
e33c334 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
bertinatto pushed a commit to bertinatto/kubernetes that referenced this pull request Mar 4, 2024
@rphillips @bertinatto
UPSTREAM: <carry>: only chown if non-windows machine
b84a88e 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
bertinatto pushed a commit to bertinatto/kubernetes that referenced this pull request Mar 4, 2024
@rphillips @bertinatto
UPSTREAM: <carry>: only chown if non-windows machine
25982c2 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
bertinatto pushed a commit to bertinatto/kubernetes that referenced this pull request Mar 5, 2024
@rphillips @bertinatto
UPSTREAM: <carry>: only chown if non-windows machine
680b70b 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
bertinatto pushed a commit to bertinatto/kubernetes that referenced this pull request Mar 6, 2024
@rphillips @bertinatto
UPSTREAM: <carry>: only chown if non-windows machine
bd68625 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
soltysh pushed a commit to soltysh/kubernetes that referenced this pull request Mar 12, 2024
@rphillips @soltysh
UPSTREAM: <carry>: only chown if non-windows machine
4edc498 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Mar 27, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
c2e35f4 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Mar 28, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
cbb381a 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
soltysh pushed a commit to soltysh/kubernetes that referenced this pull request Apr 9, 2024
@rphillips @soltysh
UPSTREAM: <carry>: only chown if non-windows machine
fad40fe 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Apr 15, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
2bccc98 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Apr 15, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
8393ee3 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Apr 15, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
0ff577f 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Apr 19, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
5226101 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Apr 22, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
c088d5e 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Apr 22, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
3dc138e 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Apr 22, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
ccc6c48 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Apr 24, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
5b2cbda 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
soltysh pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Apr 24, 2024
@rphillips @soltysh
UPSTREAM: <carry>: only chown if non-windows machine
3c1c617 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Apr 25, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
b273963 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Apr 26, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
a7858cf 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Apr 26, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
53a6e97 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request May 10, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
f2beddd 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request May 11, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
35ebb66 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request May 14, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
5d05e0d 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request May 17, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
118445d 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request May 22, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
96473d5 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request May 22, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
c7157f0 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request May 23, 2024
@rphillips @dinhxuanvu
UPSTREAM: <carry>: only chown if non-windows machine
f12da04 
Upstream worked on under kubernetes#102868

OpenShift-Rebase-Source: 5032546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@jingxu97 jingxu97

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG-Windows
  
Done (v1.23)
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

Windows Pod with RunAsUserName and a Projected Volume does not honor file permissions in the volume
9 participants
@aravindhp @k8s-ci-robot @jsturtevant @marosset @liggitt @msau42 @varshaprasad96 @dims @jingxu97