test/integration/client: test exec calls metric #102152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/test
sig/api-machinery
enj
suggested changes
May 19, 2021
Comment on lines
266
to
268
| // use the provided token for authentication. The same can be said for when the | ||
| // user specifies basic auth. | ||
| if c.HasTokenAuth() || c.HasBasicAuth() { |
There was a problem hiding this comment.
Split this change into its own PR with matching tests like #91745.
There was a problem hiding this comment.
Included in 31c53024ff9c54597a7c3da511eb5e864f5e6140. PR: https://github.com/kubernetes/kubernetes/pull/102175/files.
| echo "$EXEC_PLUGIN_OUTPUT" | ||
| echo "${EXEC_PLUGIN_OUTPUT-""}" | ||
|
|
||
| exit "${EXEC_PLUGIN_EXEC_CODE-0}" |
There was a problem hiding this comment.
Included in 31c53024ff9c54597a7c3da511eb5e864f5e6140.
Comment on lines
+476
to
+501
| previousCallsMetric := metrics.ExecPluginCalls | ||
| t.Cleanup(func() { | ||
| metrics.ExecPluginCalls = previousCallsMetric | ||
| }) |
ankeesler
force-pushed
the
exec-plugin-integration-test
branch
from
c7ed54b
to
d883387
Compare
ankeesler
force-pushed
the
exec-plugin-integration-test
branch
2 times, most recently
from
14ca8ac
to
31c5302
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankeesler, enj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm cancel |
k8s-ci-robot
removed
the
lgtm
ankeesler
force-pushed
the
exec-plugin-integration-test
branch
from
31c5302
to
57e3221
Compare
|
/triage accepted |
k8s-ci-robot
added
the
triage/accepted
k8s-ci-robot
removed
the
needs-triage
|
/assign @DangerOnTheRanger |
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
ankeesler
force-pushed
the
exec-plugin-integration-test
branch
from
57e3221
to
584acb2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/sig auth