Bump github.com/go-openapi/* to newer versions #102098
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
|
/sig api-machinery |
k8s-ci-robot
added
sig/api-machinery
| github.com/asaskevich/govalidator => github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a | ||
| github.com/go-openapi/swag => github.com/go-openapi/swag v0.19.5 | ||
| github.com/mitchellh/mapstructure => github.com/mitchellh/mapstructure v1.1.2 |
There was a problem hiding this comment.
we can't have replace directives in published modules... this means these have to be bumped as well :-/
|
update looks fine, need to bump transitive versions so lint-dependencies doesn't complain |
|
/triage accepted |
k8s-ci-robot
added
the
triage/accepted
k8s-ci-robot
removed
the
needs-triage
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
force-pushed
the
bump-goopenapi-repos-to-newer-versions
branch
from
63947d8
to
f256cde
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
kustomize is the only component that requires go-openapi right now: $ go mod why github.com/go-openapi/spec
# github.com/go-openapi/spec
k8s.io/kubernetes/pkg/kubectl/cmd/convert
k8s.io/cli-runtime/pkg/resource
sigs.k8s.io/kustomize/api/krusty
sigs.k8s.io/kustomize/kyaml/openapi
github.com/go-openapi/specDependency on go-openapi was eliminated in kustomize in kubernetes-sigs/kustomize#3827 and a new release which includes this change was also created - https://github.com/kubernetes-sigs/kustomize/releases/tag/kyaml%2Fv0.10.18 Would it help if we bumped kustomize instead to remove go-openapi completely? xref #101234 (comment), #98946 (comment), kubernetes-sigs/kustomize#3705 |
|
@nikhita possibly, |
| hasWhitespace string = ".*[[:space:]]" | ||
| hasWhitespaceOnly string = "^[[:space:]]+$" | ||
| Email string = "^(((([a-zA-Z]|\\d|[!#\\$%&'\\*\\+\\-\\/=\\?\\^_`{\\|}~]|[\\x{00A0}-\\x{D7FF}\\x{F900}-\\x{FDCF}\\x{FDF0}-\\x{FFEF}])+(\\.([a-zA-Z]|\\d|[!#\\$%&'\\*\\+\\-\\/=\\?\\^_`{\\|}~]|[\\x{00A0}-\\x{D7FF}\\x{F900}-\\x{FDCF}\\x{FDF0}-\\x{FFEF}])+)*)|((\\x22)((((\\x20|\\x09)*(\\x0d\\x0a))?(\\x20|\\x09)+)?(([\\x01-\\x08\\x0b\\x0c\\x0e-\\x1f\\x7f]|\\x21|[\\x23-\\x5b]|[\\x5d-\\x7e]|[\\x{00A0}-\\x{D7FF}\\x{F900}-\\x{FDCF}\\x{FDF0}-\\x{FFEF}])|(\\([\\x01-\\x09\\x0b\\x0c\\x0d-\\x7f]|[\\x{00A0}-\\x{D7FF}\\x{F900}-\\x{FDCF}\\x{FDF0}-\\x{FFEF}]))))*(((\\x20|\\x09)*(\\x0d\\x0a))?(\\x20|\\x09)+)?(\\x22)))@((([a-zA-Z]|\\d|[\\x{00A0}-\\x{D7FF}\\x{F900}-\\x{FDCF}\\x{FDF0}-\\x{FFEF}])|(([a-zA-Z]|\\d|[\\x{00A0}-\\x{D7FF}\\x{F900}-\\x{FDCF}\\x{FDF0}-\\x{FFEF}])([a-zA-Z]|\\d|-|\\.|_|~|[\\x{00A0}-\\x{D7FF}\\x{F900}-\\x{FDCF}\\x{FDF0}-\\x{FFEF}])*([a-zA-Z]|\\d|[\\x{00A0}-\\x{D7FF}\\x{F900}-\\x{FDCF}\\x{FDF0}-\\x{FFEF}])))\\.)+(([a-zA-Z]|[\\x{00A0}-\\x{D7FF}\\x{F900}-\\x{FDCF}\\x{FDF0}-\\x{FFEF}])|(([a-zA-Z]|[\\x{00A0}-\\x{D7FF}\\x{F900}-\\x{FDCF}\\x{FDF0}-\\x{FFEF}])([a-zA-Z]|\\d|-|_|~|[\\x{00A0}-\\x{D7FF}\\x{F900}-\\x{FDCF}\\x{FDF0}-\\x{FFEF}])*([a-zA-Z]|[\\x{00A0}-\\x{D7FF}\\x{F900}-\\x{FDCF}\\x{FDF0}-\\x{FFEF}])))\\.?$" | ||
| CreditCard string = "^(?:4[0-9]{12}(?:[0-9]{3})?|5[1-5][0-9]{14}|(222[1-9]|22[3-9][0-9]|2[3-6][0-9]{2}|27[01][0-9]|2720)[0-9]{12}|6(?:011|5[0-9][0-9])[0-9]{12}|3[47][0-9]{13}|3(?:0[0-5]|[68][0-9])[0-9]{11}|(?:2131|1800|35\\d{3})\\d{11}|6[27][0-9]{14})$" |
There was a problem hiding this comment.
@sttts we use this in vendor/k8s.io/kube-openapi/pkg/validation/strfmt/default.go and these regex changes modify our API validation for custom resources of format: creditcard, right?
| URLUsername string = `(\S+(:\S*)?@)` | ||
| URLPath string = `((\/|\?|#)[^\s]*)` | ||
| URLPort string = `(:(\d{1,5}))` | ||
| URLIP string = `([1-9]\d?|1\d\d|2[01]\d|22[0-3]|24\d|25[0-5])(\.(\d{1,2}|1\d\d|2[0-4]\d|25[0-5])){2}(?:\.([0-9]\d?|1\d\d|2[0-4]\d|25[0-5]))` |
There was a problem hiding this comment.
I don't see this one used in our validation
|
I think #102098 (comment) changes our API validation |
|
@dims @nikhita I opened kubernetes-sigs/kustomize#3827 to drop @liggitt Yeah that was one of the reasons why we moved to https://github.com/kubernetes/kube-openapi for API validation. IMO we shouldn't bump those dependencies and just upgrade kustomize to drop |
|
closing this in favor of updating kustomize and dropping the dependency altogether sounds good to me, since this update brings in behavior changes we don't want |
|
@liggitt I have a branch locally almost ready (just need the new |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
Thanks! /close |
periodic bump. Here's what we are doing:
Signed-off-by: Davanum Srinivas davanum@gmail.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: