Fix nil check #101875
Merged
Fix nil check #101875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
/sig apps |
k8s-ci-robot
added
sig/apps
soltysh
requested changes
May 10, 2021
| @@ -144,6 +144,10 @@ func SurgeCount(ds *apps.DaemonSet, numberToSchedule int) (int, error) { | |||
| if r == nil { | |||
| return 0, nil | |||
| } | |||
| // If surge is not requested, we should default to 0. | |||
| if r.MaxSurge == nil { | |||
There was a problem hiding this comment.
Can you add a unit test for this?
There was a problem hiding this comment.
Sure. Modified the existing unit to run with/without featuregate flag enabled. As discussed, I'll open a follow-up PR to modify all the tests.
|
/priority backlog |
k8s-ci-robot
added
priority/backlog
If the surge is not requested, we should return 0. We are returning an error now as r.MaxSurge is passed down as nil. This commit fixes the issue by setting the surgeCount to 0 if r.MaxSurge is nil.
ravisantoshgudimetla
force-pushed
the
fix-nil-check
branch
from
116ba4c
to
6f35e1a
Compare
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ravisantoshgudimetla, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
While working on #101742 noticed the units are failing when the surge is not configured. This PR fixes the issue by configuring the surge to 0 when maxSurge field is not configured.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: