Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Topology Aware Hints to support "Auto" value for annotation #100728

Merged
merged 1 commit into from Apr 9, 2021
Merged

Updating Topology Aware Hints to support "Auto" value for annotation #100728

merged 1 commit into from Apr 9, 2021

Conversation

robscott
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Updates Topology Aware Hints to support "Auto" value for annotation. Previously only "auto" was supported, a value that was inconsistent with Kubernetes naming patterns.

Special notes for your reviewer:

Context: kubernetes/website#27032 (comment)

Does this PR introduce a user-facing change?

"Auto" is now a valid value for the `service.kubernetes.io/topology-aware-hints` annotation.

/sig network
/priority important-soon
/assign @thockin

@robscott
Updating Topology Aware Hints to support "Auto" value for annotation
50b377f 
Previously only "auto" was supported, a value that was inconsistent with
Kubernetes naming patterns.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Mar 31, 2021
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Mar 31, 2021
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@robscott robscott mentioned this pull request Mar 31, 2021
Merged
thockin
thockin reviewed Mar 31, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@yangjunmyfm192085
Copy link
Contributor

/test pull-kubernetes-e2e-kind

@ehashman
Copy link
Member

ehashman commented Apr 7, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1cedfef into kubernetes:master Apr 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 9, 2021
@robscott robscott mentioned this pull request Apr 13, 2021
Merged
@github-actions github-actions bot mentioned this pull request Apr 21, 2021
Open
k8s-ci-robot added a commit that referenced this pull request Apr 28, 2021
@k8s-ci-robot
Merge pull request #101053 from robscott/automated-cherry-pick-of-#10…
82c76d9 
…0728-release-1.21

Automated cherry pick of #100728: Updating Topology Aware Hints to support "Auto" value for
@alexandrst88 alexandrst88 mentioned this pull request Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@dcbw dcbw Awaiting requested review from dcbw

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@robscott @fejta-bot @k8s-ci-robot @yangjunmyfm192085 @ehashman @thockin