cherry pick #100341 #98576 #95836 on 1.18 to enable SSA with APIService

[kevindelgado]

Cherry pick of #100341 #98576 #95836 on release-1.18.

#100341: Add ability to skip OpenAPI handler installation

• The line that skips open API Installation in the kube-aggregator has been removed because OpenAPI generation does not exist in kube-aggregator until 1.19.

#98576: Declare TCP default for service port protocol

• The commit declaring TCP as the default protocol has been removed because it uses features implemented in Add defaults openapi #96480 that do not exist in 1.18.
• A line has been added to set the protocol of the service object in the etcd data stub in order to account for SSA's inability to set a default protocol in 1.18

#95836: Add yaml util to unmarshal numbers into int/float

fixes #99046

Fixes using server-side apply with APIService resources

[kevindelgado]

Note that the ability to skip OpenAPI handler installation in the standalone kube-aggregator was removed from this cherry-pick compared to the 1.19 and 1.20 cherry-pick(just this one line) because OpenAPI generation was erroneously missing from kube-aggregator until 1.19 (and fixed via these two PRs (#91537 and #91525).

I figure that it makes the most sense to just drop this single conflicting line from the cherry-pick instead of

a) Also cherry-picking the two (fairly large) standalone kube-aggregator OpenAPI generation PRs or
b) Abandoning the cherry-pick for 1.18 entirely.

Let me know if you’d prefer one of those options (or another one entirely)

[kevindelgado]

/assign @apelisse
/cc @liggitt

[k8s-ci-robot]

Hi @kevindelgado. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[liggitt]

/ok-to-test

[apelisse]

Not changing the way we apply the object in the test would probably be fine too, that was mostly an improvement to the test that doesn't necessarily have to be carried into 1.18.

[kevindelgado]

Sounds good, I've removed 693d0fb from this and modified the etcd testdata to set the protocol instead of getting rid of the test improvement. I will do the same for the 1.19 backport.

Once this passes CI, PTAL @apelisse @liggitt

[apelisse]

LGTM, thanks!

[kevindelgado]

Friendly ping @liggitt (this needs to make it by the cherry-pick deadline on friday, since it's the last release of 1.18)

[liggitt]

it's a little hard to tell what is being cherry-picked and what is new in this PR now. Can you update the title/description with the master commits that are now cherry-picked, and highlight the bits that are distinct to this PR (maybe just the protocol field in the etcd stub data?)

there also look to be formatting changes in several files that are likely related to running update-gofmt with a newer version of go. revert those if possible.

[kevindelgado]

description updated, formatting updates removed, ptal @liggitt

[liggitt]

/retest
/lgtm
/approve

[kevindelgado]

ready for cherry-pick review, ping @kubernetes/release-engineering

[kevindelgado]

@liggitt can you tag this with /approve again? I think it didn't apply the label because it was still going through CI when you first applied it.

[feiskyer]

@liggitt could you approve it again? seems the original /approve comment didn't work

[liggitt]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevindelgado, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/kube-apiserver/OWNERS [liggitt]
• staging/src/k8s.io/apimachinery/pkg/OWNERS [liggitt]
• staging/src/k8s.io/apiserver/OWNERS [liggitt]
• staging/src/k8s.io/kube-aggregator/OWNERS [liggitt]
• test/integration/apiserver/OWNERS [liggitt]
• test/integration/etcd/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kevindelgado]

PR approved, ping @kubernetes/release-engineering