Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler: deprecate Policy config #102793

Closed
2 tasks
ahg-g opened this issue Jun 10, 2021 · 8 comments
Closed
2 tasks

Scheduler: deprecate Policy config #102793

ahg-g opened this issue Jun 10, 2021 · 8 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@ahg-g
Copy link
Member

ahg-g commented Jun 10, 2021

Policy config is the legacy scheduler configuration API that is being replaced with the standard ComponentConfig one.

This is a tracking issue for deprecating policy config once CC is GA.

  • Remove the flag
  • Remove legacy registry and related factory code

/sig scheduling

@ahg-g ahg-g added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 10, 2021
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jun 10, 2021
@k8s-ci-robot
Copy link
Contributor

@ahg-g: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 10, 2021
@knight42
Copy link
Member

@ahg-g Hi! I would like to help. By saying Remove legacy registry and related factory code, did you mean we should keep the deprecated flags but make them have no effect?

@ahg-g
Copy link
Member Author

ahg-g commented Jun 15, 2021

@ahg-g Hi! I would like to help. By saying Remove legacy registry and related factory code, did you mean we should keep the deprecated flags but make them have no effect?

We will likely remove them in the same cycle or even same PR.

Thanks for your interest, most likely we will do that in a later release once the community agree that CC is mature enough to replace policy. I created this issue for tracking purposes and raise awareness that this deprecation is coming.

@ahg-g
Copy link
Member Author

ahg-g commented Jun 15, 2021

@damemi @Huang-Wei @alculquicondor should we propose and announce a specific release to remove policy support so that we give the community enough buffer to switch to CC?

@damemi
Copy link
Contributor

damemi commented Jun 15, 2021

@ahg-g announcing a specific release would be very helpful, at least for us so we can propagate that timeline downstream to customers. +1

@ahg-g
Copy link
Member Author

ahg-g commented Jun 15, 2021

@damemi what is a reasonable target for your customers?

@damemi
Copy link
Contributor

damemi commented Jun 15, 2021

@ahg-g we have been planning for a 1.23 removal (btw, I think this is a duplicate of the original issue for deprecating policy config: #92143, we should close one of them)

So, we are fine moving forward with that for a timeline

@ahg-g
Copy link
Member Author

ahg-g commented Jun 15, 2021

oh, I didn't see that one, closing this. Lets move the discussion on setting a target release for the removal to the other issue.

@ahg-g ahg-g closed this as completed Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Development

No branches or pull requests

4 participants