Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github.com/golang/protobuf deprecated #118135

Closed
ohDaddyPlease opened this issue May 19, 2023 · 5 comments
Closed

github.com/golang/protobuf deprecated #118135

ohDaddyPlease opened this issue May 19, 2023 · 5 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ohDaddyPlease
Copy link

What would you like to be added?

I suggest replacing gogo/protobuf and golang/protobuf with google/protobuf

Why is this needed?

golang/protobuf#1306 deprecates github.com/golang/protobuf in favour of google.golang.org/protobuf
@ohDaddyPlease ohDaddyPlease added the kind/feature Categorizes issue or PR as related to a new feature. label May 19, 2023
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 19, 2023
@ohDaddyPlease
Copy link
Author

/sig api-machinery
/kind cleanup

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 19, 2023
@ohDaddyPlease ohDaddyPlease mentioned this issue May 19, 2023
Closed
@BenTheElder
Copy link
Member

see also: #96564

@cici37
Copy link
Contributor

cici37 commented May 23, 2023

/cc @liggitt
Not quite sure if the replacement has been planned? :)
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 23, 2023
@liggitt
Copy link
Member

liggitt commented May 23, 2023

/close
in favor of #96564

@k8s-ci-robot
Copy link
Contributor

@liggitt: Closing this issue.

In response to this:

/close
in favor of #96564

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@BenTheElder @liggitt @cici37 @ohDaddyPlease @k8s-ci-robot