Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not happen: OpenAPI V3 merge schema conflict when applying CRDs #109871

Closed
brandond opened this issue May 6, 2022 · 5 comments · Fixed by #109880
Closed

Should not happen: OpenAPI V3 merge schema conflict when applying CRDs #109871

brandond opened this issue May 6, 2022 · 5 comments · Fixed by #109880
Assignees
@Jefftree
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@brandond
Copy link

brandond commented May 6, 2022 •
edited

What happened?

Seeing the following errors in kube-apiserver logs when CRDs are applied:

W0505 23:04:14.625582      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.FieldsV1
W0505 23:04:14.625617      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.Time
W0505 23:04:14.625634      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.Status
W0505 23:04:14.625649      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.Preconditions
W0505 23:04:14.625657      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.Patch
W0505 23:04:14.625683      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta
W0505 23:04:14.625702      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.StatusCause
W0505 23:04:14.625715      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.DeleteOptions
W0505 23:04:14.625732      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.StatusDetails
W0505 23:04:14.625747      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.ManagedFieldsEntry
W0505 23:04:14.625760      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.OwnerReference
W0505 23:04:14.625768      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.ListMeta
W0505 23:04:14.632779      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.Preconditions
W0505 23:04:14.632824      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta
W0505 23:04:14.632840      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.ManagedFieldsEntry
W0505 23:04:14.632864      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.OwnerReference
W0505 23:04:14.632879      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.DeleteOptions
W0505 23:04:14.632925      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.Patch
W0505 23:04:14.632966      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.Status
W0505 23:04:14.633002      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.StatusDetails
W0505 23:04:14.633013      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.StatusCause
W0505 23:04:14.633049      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.FieldsV1
W0505 23:04:14.633060      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.Time
W0505 23:04:14.633110      55 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.ListMeta

What did you expect to happen?

No errors in logs

How can we reproduce it (as minimally and precisely as possible)?

Apply any CRD manifest

Anything else we need to know?

No response

Kubernetes version

root@rke2-server-1:/# kubectl version -o yaml
clientVersion:
  buildDate: "2022-05-05T23:36:15Z"
  compiler: gc
  gitCommit: 4ce5a8954017644c5420bae81d72b09b735c21f0
  gitTreeState: clean
  gitVersion: v1.24.0+rke2r1
  goVersion: go1.18.1b7
  major: "1"
  minor: "24"
  platform: linux/amd64
kustomizeVersion: v4.5.4
serverVersion:
  buildDate: "2022-05-05T23:36:15Z"
  compiler: gc
  gitCommit: 4ce5a8954017644c5420bae81d72b09b735c21f0
  gitTreeState: clean
  gitVersion: v1.24.0+rke2r1
  goVersion: go1.18.1b7
  major: "1"
  minor: "24"
  platform: linux/amd64

Cloud provider

OS version

root@rke2-server-1:/# cat /etc/os-release
NAME="Ubuntu"
VERSION="20.04.4 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.4 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

root@rke2-server-1:/# uname -a
Linux rke2-server-1 5.17.4-051704-generic #202204200842 SMP PREEMPT Wed Apr 20 09:30:50 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Install tools

Rancher RKE2

Container runtime (CRI) and version (if applicable)

containerd 1.6.4

Related plugins (CNI, CSI, ...) and versions (if applicable)

canal
@brandond brandond added the kind/bug Categorizes issue or PR as related to a bug. label May 6, 2022
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 6, 2022
@brandond
Copy link
Author

brandond commented May 6, 2022

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 6, 2022
@brandond brandond mentioned this issue May 6, 2022
Closed
@Jefftree Jefftree mentioned this issue May 7, 2022
Merged
@Jefftree
Copy link
Member

Jefftree commented May 7, 2022

/assign

@apelisse
Copy link
Member

apelisse commented May 9, 2022

Did this cause any specific trouble to your cluster @brandond? I'm curious what the impact/severity of this is.

@brandond
Copy link
Author

brandond commented May 9, 2022 •
edited

Everything seems to work fine, but there's a bunch of log spew every time a CRD manifest is loaded. In K3s we mix all the control-plane component logs together in a single pair of stdout/stderr streams so it's quite noisy, compared to previous releases.

The fact that these come out at WARN level with a scary Should not happen prefix makes them look pretty serious, and I expect we will get a fair bit of users asking about it once we release.

@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 10, 2022
@liggitt liggitt added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/regression Categorizes issue or PR as related to a regression from a prior release. labels May 10, 2022
@ialidzhikov ialidzhikov mentioned this issue Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jefftree Jefftree

Labels
kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove warning log for crd merging Jefftree/kubernetes
6 participants
@brandond @liggitt @apelisse @fedebongio @Jefftree @k8s-ci-robot