Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kindest/node image to v1.24.7 #6900

Merged

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Oct 25, 2022

How to categorize this PR?

/area testing
/kind cleanup

What this PR does / why we need it:
While looking into test failure reasons, in the kind's kube-apiserver logs I noticed the following logs:

2022-10-25T12:40:14.755270505Z stderr F W1025 12:40:14.755061       1 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta
2022-10-25T12:40:14.755300989Z stderr F W1025 12:40:14.755093       1 merge.go:121] Should not happen: OpenAPI V3 merge schema conflict on io.k8s.apimachinery.pkg.apis.meta.v1.ListMeta
...

This is a known issue fixed in v1.24.1 - ref kubernetes/kubernetes#109871.
To prevent having test failures that are potentially caused by already fixed upstream issues, I guess it makes sense to update the kindest/node image to the latest available patch release.

Which issue(s) this PR fixes:
Does not fix a particular issue

Release note:

NONE

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 25, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/testing Testing related kind/cleanup Something that is not needed anymore and can be cleaned up cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Oct 25, 2022
@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 25, 2022
@ialidzhikov ialidzhikov changed the title Update kindest/node image to v1.24.6 Update kindest/node image to v1.24.7 Oct 30, 2022
@ialidzhikov ialidzhikov marked this pull request as ready for review October 30, 2022 13:17
@gardener-prow gardener-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2022
@gardener-prow gardener-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2022
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2022
@gardener-prow gardener-prow bot merged commit 2e80adc into gardener:master Oct 31, 2022
@ialidzhikov ialidzhikov deleted the enh/update-kind-node-image branch November 12, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Testing related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants