-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for “non exhaustive enums” #109463
Comments
@sftim: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/wg api-expression |
Note that the inclusion of these in 1.23 docs was an accident... the feature was in alpha state and should not have been enabled in 1.23. The openapi file in release-1.23 and master branches once again has the same amount of information as the API definition in release-1.22 |
Ah, got it. Definitely a feature request, then. |
The most relevant reason why enums were removed from docs sound like the CSR test cases. I'm wondering if that is something we need to fix rather than dropping enums from docs. Without this information, users have no idea what values are acceptable for those fields. The |
I am a beginner and willing to work on with some guidance if fine please assign to me |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What happened?
Following a bugfix, we now have a gap where these non-exhaustive, enum-like field values are not documented. Folks will previously have found those explanations useful.
See kubernetes/website#32833 (review) for an example where the v1.23 docs enumerate taint effects and list meanings (
NoExecute
,NoSchedule
andPreferNoSchedule
) but the v1.24 docs won't.https://kubernetes.io/docs/reference/kubernetes-api/cluster-resources/node-v1/#NodeSpec is the URL of the v1.23 docs at the time of writing; that will soon change to be https://v1-23.docs.kubernetes.io/docs/reference/kubernetes-api/cluster-resources/node-v1/
What did you expect to happen?
What I hoped for: API reference information covers known field values, even when the field values known to Kubernetes are not exhaustive.
Aside: I think there are multiple ways to tackle this issue. I don't have a strong view on which might be the best approach.
How can we reproduce it (as minimally and precisely as possible)?
(After the v1.24 release) look at the API reference for Node. See if the possible effects are enumerated and explained.
Anything else we need to know?
This issue covers 3 repos:
Kubernetes version
v1.24
Cloud provider
Netlify 😉
OS version
not applicable
Install tools
not applicable
Container runtime (CRI) and version (if applicable)
not applicable
Related plugins (CNI, CSI, ...) and versions (if applicable)
not applicable
The text was updated successfully, but these errors were encountered: