Merge pull request #110548 from benluddy/cel-unstructuredtoval-benchm…

…ark-fixture Do test fixture setup outside cel.UnstructuredToVal benchmark loop.
kubernetes · Jun 29, 2022 · d0f5496 · d0f5496
2 parents ab4aa18 + 91179d4
commit d0f5496
Showing 1 changed file with 28 additions and 24 deletions.
diff --git a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/cel/values_test.go b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/cel/values_test.go
@@ -621,44 +621,48 @@ func TestMapper(t *testing.T) {
 }
 
 func BenchmarkUnstructuredToVal(b *testing.B) {
+	u := []interface{}{
+		map[string]interface{}{
+			"key": "a",
+			"val": 1,
+		},
+		map[string]interface{}{
+			"key": "b",
+			"val": 2,
+		},
+		map[string]interface{}{
+			"key": "@b",
+			"val": 2,
+		},
+	}
+
 	b.ReportAllocs()
 	b.ResetTimer()
 
 	for n := 0; n < b.N; n++ {
-		if val := UnstructuredToVal([]interface{}{
-			map[string]interface{}{
-				"key": "a",
-				"val": 1,
-			},
-			map[string]interface{}{
-				"key": "b",
-				"val": 2,
-			},
-			map[string]interface{}{
-				"key": "@b",
-				"val": 2,
-			},
-		}, &mapListSchema); val == nil {
+		if val := UnstructuredToVal(u, &mapListSchema); val == nil {
 			b.Fatal(val)
 		}
 	}
 }
 
 func BenchmarkUnstructuredToValWithEscape(b *testing.B) {
+	u := []interface{}{
+		map[string]interface{}{
+			"key": "a.1",
+			"val": "__i.1",
+		},
+		map[string]interface{}{
+			"key": "b.1",
+			"val": 2,
+		},
+	}
+
 	b.ReportAllocs()
 	b.ResetTimer()
 
 	for n := 0; n < b.N; n++ {
-		if val := UnstructuredToVal([]interface{}{
-			map[string]interface{}{
-				"key": "a.1",
-				"val": "__i.1",
-			},
-			map[string]interface{}{
-				"key": "b.1",
-				"val": 2,
-			},
-		}, &mapListSchema); val == nil {
+		if val := UnstructuredToVal(u, &mapListSchema); val == nil {
 			b.Fatal(val)
 		}
 	}