Skip to content

Commit

Permalink
Merge pull request #108987 from soltysh/deprecate_long_version
Browse files Browse the repository at this point in the history
Start deprecating long/golang version information
  • Loading branch information
k8s-ci-robot committed Mar 25, 2022
2 parents 317f8af + 43c09f6 commit 5a651ea
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions staging/src/k8s.io/kubectl/pkg/cmd/version/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ func NewCmdVersion(f cmdutil.Factory, ioStreams genericclioptions.IOStreams) *co
}
cmd.Flags().BoolVar(&o.ClientOnly, "client", o.ClientOnly, "If true, shows client version only (no server required).")
cmd.Flags().BoolVar(&o.Short, "short", o.Short, "If true, print just the version number.")
cmd.Flags().MarkDeprecated("short", "and will be removed in the future. The --short output will become the default.")
cmd.Flags().StringVarP(&o.Output, "output", "o", o.Output, "One of 'yaml' or 'json'.")
return cmd
}
Expand Down Expand Up @@ -143,6 +144,7 @@ func (o *Options) Run() error {
fmt.Fprintf(o.Out, "Server Version: %s\n", versionInfo.ServerVersion.GitVersion)
}
} else {
fmt.Fprintf(o.ErrOut, "WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short. Use --output=yaml|json to get the full version.\n")
fmt.Fprintf(o.Out, "Client Version: %#v\n", *versionInfo.ClientVersion)
fmt.Fprintf(o.Out, "Kustomize Version: %s\n", versionInfo.KustomizeVersion)
if versionInfo.ServerVersion != nil {
Expand Down

0 comments on commit 5a651ea

Please sign in to comment.