-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gnostic to drop jsonschema dependency #288
Conversation
@@ -11,7 +11,7 @@ require ( | |||
github.com/go-openapi/jsonreference v0.19.3 | |||
github.com/go-openapi/swag v0.19.5 | |||
github.com/golang/protobuf v1.5.2 | |||
github.com/google/gnostic v0.6.6 | |||
github.com/google/gnostic v0.5.7-v3refs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't a semantic version, which means go mod tidy
wasn't run on this, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did run go mod tidy
on this, which removed the jsonschema dependencies. The version name is valid per semver https://semver.org/#backusnaur-form-grammar-for-valid-semver-versions (pre-release).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh... I didn't realize go preserved that... that's fun
want to take a stab at the corresponding k8s.io/kubernetes bump PR based on this before merge, just to make sure the dependency diff there looks right? you can see what it will look like with |
Yep, I have it in kubernetes/kubernetes#108644. The dependencies look correct and jsonschema and its tree of dependencies were removed. (github.com/jefftree/kube-openapi v0.0.8-gnostic corresponds to this branch) |
great, that looks way better. this will let us make progress, but we'll still want to resolve google/gnostic#317 asap, since we're effectively blocked from picking up gnostic bugfixes at this point /lgtm |
Agreed, that's exciting, thanks @Jefftree ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, Jefftree The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The short term fix is to use this specific gnostic version which includes our OpenAPI V3 bug fix and does not pull in additional dependencies.
Gnostic will be split into two repos in the future, with a dedicated library for generated models to avoid pulling in unnecessary dependencies.
/assign @apelisse
/assign @liggitt