Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Use droplet ID for node names in DO #16004

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP Use droplet ID for node names in DO #16004

wants to merge 3 commits into from

Conversation

hakman
Copy link
Member

@hakman hakman commented Oct 6, 2023

/cc @rifelpet

@rifelpet
Use hostnames for node names in DO
a2ac9d3 
This matches GCE and AWS and matches an assumption in failing e2e tests that node names match their hostname

Signed-off-by: Peter Rifel <pgrifel@gmail.com>
@rifelpet
Have kops-controller authorize droplet names instead of IPs
7a37a36
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/documentation area/nodeup area/provider/digitalocean Issues or PRs related to digitalocean provider labels Oct 6, 2023
@hakman
Copy link
Member Author

hakman commented Oct 6, 2023

/test pull-kops-e2e-kubernetes-do-dns-none

@k8s-ci-robot k8s-ci-robot added area/api size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 6, 2023
@hakman
Copy link
Member Author

hakman commented Oct 6, 2023

/test pull-kops-e2e-kubernetes-do-dns-none

@hakman
Copy link
Member Author

hakman commented Oct 6, 2023

/test pull-kops-e2e-kubernetes-do-dns-none

@rifelpet
Copy link
Member

rifelpet commented Oct 6, 2023

Whats the advantage of using the droplet ID over the IP address for the node name? I suppose it matches AWS' instance ID node names, any other benefits?

@hakman
Copy link
Member Author

hakman commented Oct 6, 2023 •
edited

Whats the advantage of using the droplet ID over the IP address for the node name? I suppose it matches AWS' instance ID node names, any other benefits?

See https://github.com/digitalocean/digitalocean-cloud-controller-manager/blob/master/docs/getting-started.md#--provider-iddigitaloceandroplet-id

I am also curious if this way it will pass that failing test.

@k8s-ci-robot
Copy link
Contributor

@hakman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-kubernetes-do-dns-none 73dc8f7 link true /test pull-kops-e2e-kubernetes-do-dns-none
pull-kops-kubernetes-e2e-ubuntu-gce-build 73dc8f7 link true /test pull-kops-kubernetes-e2e-ubuntu-gce-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees
No one assigned
Labels
area/api area/documentation area/nodeup area/provider/digitalocean Issues or PRs related to digitalocean provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hakman @k8s-ci-robot @rifelpet @k8s-triage-robot