Set log level through function #389
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tshiyuoo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
needs-triage
|
We've discussed this before. Please read up on #336 and if you are interested in adding a non-flag API, then do it as described there. Adding individual new API calls in the main klog is not how we want to do this. |
| @@ -438,6 +438,11 @@ func InitFlags(flagset *flag.FlagSet) { | |||
| }) | |||
| } | |||
|
|
|||
| // SetVerbosity set log level through function. | |||
| func SetVerbosity(level Level) { | |||
| logging.verbosity = level | |||
There was a problem hiding this comment.
This isn't thread-safe. Set has to be used.
|
/assign @pohly |
k8s-ci-robot
added
triage/accepted
|
/close Please reopen a new PR with the approach described above, if you are interested. |
|
@pohly: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
The log level can be set through functions,
Not only can it be set by flags, but also by functions.
A app has a debug flag. enable the debug flag parameter, I hope that all the klog logs can be printed out.
But the klog log level can only be set through flag
Special notes for your reviewer:
Release note: