Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programmatically set oneOutput flag #373

Closed

Conversation

danmillwood
Copy link

This enhancement enables an application to programatically set the logging.oneOutput flag without needing to expose the klog flags on the command line. It aligns with the existing functions LogToStderr(..) and SetOutputBySeverity(..), such that one can direct messages to different output destinations and control whether those messages are only written to their native severity level.

What this PR does / why we need it:

The enhancement introduces a new function SetOneOutput(bool) that updates the value of the logging.oneOutput flag.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Release note:

addition of SetOneOutput function

This enhancement enables an application to programatically set the oneOutput flag
without needing to expose flags on the command line. It aligns with the existing
functions LogToStderr and SetOutputBySeverity, such that one can direct messages
to different output destinations and control whether those messages are only
written to their native severity level.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 29, 2023
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danmillwood
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 29, 2023
@k8s-ci-robot k8s-ci-robot requested a review from pohly March 29, 2023 10:55
@k8s-ci-robot
Copy link

This issue is currently awaiting triage.

If klog contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link

Welcome @danmillwood!

It looks like this is your first PR to kubernetes/klog 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/klog has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 29, 2023
@pohly
Copy link

pohly commented Mar 29, 2023

This enhancement enables an application to programatically set the logging.oneOutput flag without needing to expose the klog flags on the command line.

A program doesn't need to do that. See #336

That's the solution that I prefer, not adding more individual API calls.

@danmillwood
Copy link
Author

Thanks for the pointer. I hadn't appreciated there was an alternative.

@danmillwood danmillwood deleted the programmatic-set-oneoutput branch March 29, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants