Added support for external setting of log verbosity through the klog. Addresses issue #336

[fire833]

This PR proposes API changes to allow external configuration of specifically logging verbosity outside of simply using flags.

This addresses #336 .

I managed to implement this in a few minutes and figured I would open a PR for the sake of openness. Let me know if there is still apprehension on making an API change like this one.

Signed-off by: Kendall Tauser kttpsy@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: fire833 / name: Kendall Tauser (b66b498)

[k8s-ci-robot]

Welcome @fire833!

It looks like this is your first PR to kubernetes/klog 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/klog has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fire833
To complete the pull request process, please assign dims after the PR has been reviewed.
You can assign the PR to them by writing /assign @dims in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pohly]

Why just one value and not one API for every single option that klog has?

I'm just asking a leading question to show how this is a slippery slope that can easily lead a) to a much larger effort and b) much larger API.

[pohly]

/close

Let's use the approach outlined in #336 (comment) instead. PRs welcome...

[k8s-ci-robot]

@pohly: Closed this PR.

In response to this:

/close

Let's use the approach outlined in #336 (comment) instead. PRs welcome...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.