Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ktesting: handle test completion #337

Merged
merged 3 commits into from Jul 6, 2022
Merged

ktesting: handle test completion #337

merged 3 commits into from Jul 6, 2022

Commits on Jun 29, 2022

  1. ktesting: use black box testing 

    It makes it more obvious what calls to the ktesting API will look like in real
code.
    @pohly
    pohly committed Jun 29, 2022
    Copy the full SHA
    66544b3 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. ktesting: fix type assertion 

    Due a missing space, _TL was a variable of type NopTL instead
of asserting that NopTL implements the TL interface.
    @pohly
    pohly committed Jul 4, 2022
    Copy the full SHA
    78f38f6 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. ktesting: stop using testing.T when test completes 

    When testing.T.Log gets called after the test has completed, it panics. There's
also a data race (kubernetes/kubernetes#110854).

Normally that should never happen because tests should ensure that all
goroutines have stopped before returning. But sometimes it is not possible to
do that. ktesting now automatically protects against that by registering a
cleanup function and redirecting all future output into klog.
    @pohly
    pohly committed Jul 6, 2022
    Copy the full SHA
    9405f8e View commit details
    Browse the repository at this point in the history