Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klog.Fatal backtrace revert #328

Merged
merged 2 commits into from Jun 20, 2022

Commits on Jun 13, 2022

  1. klog.Fatal: revert dumping of all stack backtraces to stderr

    This is a revert of kubernetes#79.
    
    Dumping the stack backtraces of all goroutines to stderr is not useful for
    processes which have many goroutines. The console buffer overflows and the
    original error which got dumped earlier is no longer visible. Even in CI
    systems where stderr is captured the full dump is often not useful.
    
    This was pointed out as a potential problem during the original PR review but
    only got more attention after the updated klog got merged into Kubernetes and
    developers there started to see the longer output.
    pohly committed Jun 13, 2022
    Copy the full SHA
    c977919 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. klog.Fatal: document behavior and alternatives

    After reverting kubernetes#79 users who want the
    full dump of all goroutines can still get it by calling
    
       github.com/go-logr/lib.Backtrace(lib.BacktraceAll(true)).
    pohly committed Jun 14, 2022
    Copy the full SHA
    c5c3132 View commit details
    Browse the repository at this point in the history