Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix goroutine leak: make flushDaemon stoppable #293

Merged
merged 5 commits into from Feb 27, 2022
Merged

Fix goroutine leak: make flushDaemon stoppable #293

merged 5 commits into from Feb 27, 2022

Commits on Feb 19, 2022

  1. Make flushDaemon stoppable and testable 

    Refactor flushDaemon function into a seperate struct. Instead of
starting the daemon in the init function, it is now started during
createFile, where it is only used. Add function to stop daemon.
This way, users can gracefully shut down klog and prevent goroutine
leakage. Test daemon flushing.
    @katexochen
    katexochen committed Feb 19, 2022
    Copy the full SHA
    0d5c8b7 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. fixup! Make flushDaemon stoppable and testable

    @katexochen
    katexochen committed Feb 24, 2022
    Copy the full SHA
    7ad18de View commit details
    Browse the repository at this point in the history

  2. fixup! Make flushDaemon stoppable and testable

    @katexochen
    katexochen committed Feb 24, 2022
    Copy the full SHA
    b6757a5 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2022

  1. fixup! Make flushDaemon stoppable and testable

    @katexochen
    katexochen committed Feb 26, 2022
    Copy the full SHA
    31a05ea View commit details
    Browse the repository at this point in the history

  2. fixup! Make flushDaemon stoppable and testable

    @katexochen
    katexochen committed Feb 26, 2022
    Copy the full SHA
    ec08484 View commit details
    Browse the repository at this point in the history