Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use printlnDepth function in *lnDepth log function calls. #292

Closed
wants to merge 1 commit into from
Closed

Use printlnDepth function in *lnDepth log function calls. #292

wants to merge 1 commit into from

Conversation

s3rj1k
Copy link

@s3rj1k s3rj1k commented Feb 10, 2022

Use printlnDepth function in *lnDepth log function calls.

Signed-off-by: s3rj1k evasive.gyron@gmail.com

@s3rj1k
Use printlnDepth function in *lnDepth log function calls.
98c29db 
Signed-off-by: s3rj1k <evasive.gyron@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2022
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: s3rj1k
To complete the pull request process, please assign thockin after the PR has been reviewed.
You can assign the PR to them by writing /assign @thockin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@s3rj1k
Copy link
Author

s3rj1k commented Feb 10, 2022

Bug found by @pohly, introduced after merge of #280

@pohly
Copy link

pohly commented Feb 10, 2022

/hold

I have a larger PR coming with the same fix. That PR also contains a unit test.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 10, 2022
@k8s-ci-robot
Copy link

@s3rj1k: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pohly
Copy link

pohly commented Feb 15, 2022

/close

Resolved via PR #287

@k8s-ci-robot
Copy link

@pohly: Closed this PR.

In response to this:

/close

Resolved via PR #287

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s3rj1k s3rj1k deleted the println_fix branch February 15, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyxning andyxning Awaiting requested review from andyxning

@detiber detiber Awaiting requested review from detiber

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@s3rj1k @k8s-ci-robot @pohly