Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log filter: ignored by V, used during log call #290

Merged
merged 1 commit into from Feb 9, 2022

Commits on Feb 8, 2022

  1. log filter: ignored by V, used during log call

    It's not entirely clear why the filter was copied into Verbose. The only
    semantic difference is when Verbose get stored and then the filter gets
    modified:
    
    klogV := klog.V(5)
    klog.SetLogFilter(...)
    klogV.Info(...)
    
    This seems like a very unlikely code pattern and goes against the intention of
    first initializing logging, then using it.
    
    Therefore we can undo the size increase in Verbose and only retrieve the filter
    when it is needed.
    pohly committed Feb 8, 2022
    Copy the full SHA
    892e4f4 View commit details
    Browse the repository at this point in the history