Merge pull request #305 from pohly/flush-and-exit

remove side effects of tests
kubernetes · Mar 15, 2022 · ae0c078 · ae0c078
2 parents 6631b8c + cd54fdc
commit ae0c078
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/contextual_test.go b/contextual_test.go
@@ -24,6 +24,8 @@ import (
 )
 
 func ExampleSetLogger() {
+	defer klog.ClearLogger()
+
 	// Logger is only used as backend, Background() returns klogr.
 	klog.SetLogger(logr.Discard())
 	fmt.Printf("logger after SetLogger: %T\n", klog.Background().GetSink())

diff --git a/exit_test.go b/exit_test.go
@@ -24,10 +24,13 @@ import (
 
 func ExampleFlushAndExit() {
 	// Set up klog so that we can test it below.
+
 	var fs flag.FlagSet
 	klog.InitFlags(&fs)
 	fs.Set("skip_headers", "true")
 	defer flag.Set("skip_headers", "false")
+	fs.Set("logtostderr", "false")
+	defer fs.Set("logtostderr", "true")
 	klog.SetOutput(os.Stdout)
 	defer klog.SetOutput(nil)
 	klog.OsExit = func(exitCode int) {