Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap k8s-infra-prow GCP project #6740

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bootstrap k8s-infra-prow GCP project #6740

wants to merge 2 commits into from
+515 −0

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Apr 19, 2024 •
edited

This project will host 3 key services:

  • The prow control plane
  • A utility cluster that runs ArgoCD, Atlantis and our unified Grafana instance
  • Host gcr.io/k8s-prow replacement at us-docker.pkg.dev/k8s-infra-prow/images

Before Aug 2024, I want to have the images being dual published to both locations and the utility cluster to be fully operational.

/cc @ameukam @dims @BenTheElder

@k8s-ci-robot k8s-ci-robot added area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 19, 2024
@upodroid
Copy link
Member Author

/hold to push further commits after initial approval

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024
@upodroid upodroid mentioned this pull request Apr 21, 2024
Merged
@dims
Copy link
Member

dims commented Apr 22, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@upodroid
Copy link
Member Author

I deployed all the infra in the PR.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@upodroid upodroid added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 17, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2024
@upodroid
Copy link
Member Author

The infra has been deployed, this PR is ready to merged

@upodroid upodroid requested a review from xmudrii May 23, 2024 11:50
xmudrii
xmudrii approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some non-blocking nits, feel free to discard them or fix them later
/lgtm
/approve
/hold
feel free to unhold when ready

infra/gcp/terraform/k8s-infra-prow/buckets.tf
type = "Delete"
}
condition = {
age = 7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to document what is 7 exactly (e.g. days, months, etc).

infra/gcp/terraform/k8s-infra-prow/gke.tf
version = "~> 30.2"
project_id = module.project.project_id
name = "prow"
region = "us-central1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should eventually be a variable because we use it in many places

infra/gcp/terraform/k8s-infra-prow/gke.tf
enable_private_nodes = true
enable_cost_allocation = true
gateway_api_channel = "CHANNEL_STANDARD"
master_ipv4_cidr_block = "10.254.0.16/28"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to document how did we choose that value

infra/gcp/terraform/k8s-infra-prow/gke.tf
enable_l4_ilb_subsetting = true
enable_private_nodes = true
enable_cost_allocation = true
master_ipv4_cidr_block = "10.254.0.0/28"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to document how did we choose that value

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, upodroid, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@ameukam ameukam Awaiting requested review from ameukam

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@upodroid @dims @k8s-ci-robot @xmudrii