-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4004: promote stage to beta #4625
base: master
Are you sure you want to change the base?
KEP-4004: promote stage to beta #4625
Conversation
HirazawaUi
commented
May 9, 2024
- One-line PR description: Promote the stage of KEP to beta.
- Issue link: Deprecate status.nodeInfo.kubeProxyVersion field #4004
- Other comments:
/assign @danwinship |
1b0a0c6
to
1568303
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to KEP reviewers: I'd have named this gate LegacyNodeKubeProxyVersion
or NodeKubeProxyVersion
. I'ts feasible that we still can (by changing the feature gate name for beta)
Even when we intend to disable something, the feature gate is typically named after the thing we want to disable. It means in docs we don't ask people to, eg, “enable DisableNodeKubeProxyVersion” or “enable the DisableNodeKubeProxyVersion feature gate” - both of those jar, but the first one especially so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we ever do that? (Change a feature gate name between alpha and beta?)
If it matters, we're pretty sure no one will actually need to set this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have changed gate names, but I wouldn't think it's worth it here.
It was more feedback about how to review future KEPs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we ever do that? (Change a feature gate name between alpha and beta?)
If it matters, we're pretty sure no one will actually need to set this.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danwinship, HirazawaUi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |