Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP 3077: contextual logging: simplify scope, avoid transition #3222

Merged
merged 1 commit into from Mar 16, 2022
Merged

KEP 3077: contextual logging: simplify scope, avoid transition #3222

merged 1 commit into from Mar 16, 2022

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Feb 14, 2022

  • One-line PR description: simplify scope, avoid transition

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Feb 14, 2022
@pohly pohly force-pushed the contextual-logging branch 2 times, most recently from f4d57c1 to a7c562d Compare February 14, 2022 15:39
thockin
thockin reviewed Feb 14, 2022
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SGTM, but I don't know klog as deeply as I would need to be authoritative on the proposal.

@pohly
Copy link
Contributor Author

pohly commented Feb 14, 2022

It's the approach preferred by @dims. I think depending on klog (the package) without actually using the legacy code in klog.go will be fine.

@dims: do you want to LGTM and then hand it over to @thockin for approval?

This was referenced Feb 16, 2022
Merged
Merged
Open
@pohly pohly mentioned this pull request Feb 23, 2022
Closed
@pohly
contextual logging: simplify scope, avoid transition
42bb993 
A less ambitious goal is to just remove the usage of the traditional klog
logging API and the hard dependency on the klog logging implementation and
still keeping k8s.io/klog/v2 as dependency.

The main advantage is that there's no need for a transition to a new
k8s.io/klogr package.
thockin
thockin reviewed Mar 14, 2022
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2022
@dims
Copy link
Member

dims commented Mar 14, 2022

/assign @ehashman @dashpole

@dims
Copy link
Member

dims commented Mar 14, 2022

/lgtm

@dashpole
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, pohly, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2f7a0c7 into kubernetes:master Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@dashpole dashpole dashpole approved these changes

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@ehashman ehashman Awaiting requested review from ehashman

Assignees

@dims dims

@dashpole dashpole

@ehashman ehashman

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pohly @dims @dashpole @k8s-ci-robot @thockin @ehashman