Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate Ready Pods in Job status to Beta #3111

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Graduate Ready Pods in Job status to Beta #3111

merged 3 commits into from
Jan 24, 2022

Conversation

alculquicondor
Copy link
Member

  • One-line PR description: Update milestone for Beta

  • Issue link: Track Ready Pods in Job status #2879

  • Other comments:

    • Added links to testgrid
    • The PRR questionnaire was already answered in the alpha release.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Jan 5, 2022
@alculquicondor alculquicondor mentioned this pull request Jan 5, 2022
Closed
14 tasks
@alculquicondor
Copy link
Member Author

/assign @soltysh @wojtek-t

soltysh
soltysh reviewed Jan 18, 2022
View reviewed changes
keps/sig-apps/2879-ready-pods-job-status/README.md

#### Beta

- Feature gate enabled by default.
- Existing E2E and conformance tests passing.
- Existing [E2E] and [conformance] tests passing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see some scalability tests results for beta graduation, since enabling this feature might increase in job status updates and having a clear information what the impact is is an important factor.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a section What specific metrics should inform a rollback? that would be especially important for the above question. The next question Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested? I'd like to see answered as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wojtek-t how do we go about scalability?
I could certainly add an scalability test. We have useful metrics from the job controller too.
Is there a prow job we can reuse?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

questions updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're testing Jobs as part of our regular e2e scalability load test (not super extensively, but there are Jobs there).
I'm not sure I would be adding a dedicated CI test for that, but I certainly agree that seeing results from some manual test, that is being "bad case" for this feature would be desired.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added scalability tests (that we need to add) as graduation criteria.

soltysh
soltysh approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2022
@wojtek-t
Copy link
Member

/lgtm
/approve PRR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, soltysh, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8f81feb into kubernetes:master Jan 24, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 24, 2022
@jprzychodzen jprzychodzen mentioned this pull request Jan 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@soltysh soltysh soltysh approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

Assignees

@soltysh soltysh

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alculquicondor @wojtek-t @k8s-ci-robot @soltysh