Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refresh development container #8828

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

shu-mutou
Copy link
Contributor

Support for new Kubernetes Dashboard configuration.
Omitted connecting to an external K8s cluster.
Currently, it only supports kind k8s clusters built by scripts in this repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2024
@shu-mutou shu-mutou added kind/feature Categorizes issue or PR as related to a new feature. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.20%. Comparing base (a49364c) to head (bbee95e).

❗ Current head bbee95e differs from pull request most recent head b7540d7. Consider uploading reports for the commit b7540d7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8828   +/-   ##
=======================================
  Coverage   37.19%   37.20%           
=======================================
  Files         255      255           
  Lines       11156    11149    -7     
  Branches      157      158    +1     
=======================================
- Hits         4150     4148    -2     
- Misses       6756     6790   +34     
+ Partials      250      211   -39     

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 23, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 3, 2024
@shu-mutou
Copy link
Contributor Author

@maciaszczykm @floreks PTAL Thanks!

@floreks
Copy link
Member

floreks commented Apr 4, 2024

make serve and make run are broken now and do not work.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 9, 2024
@shu-mutou
Copy link
Contributor Author

/checkcla

@shu-mutou
Copy link
Contributor Author

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 11, 2024
@shu-mutou
Copy link
Contributor Author

@floreks @maciaszczykm dashboard runs properly with this development container.
Please try hack/develop/run-dev-container.sh. Then try followings.

To add a role with full access for development and get its token
to log into the Dashboard, see followings:

1. Run terminal in development container.
    docker exec -it k8s-dashboard-dev gosu user bash

2. Set env for kubeconfig on development container
    export KUBECONFIG=/go/src/github.com/kubernetes/dashboard/.tmp/kubeconfig

3. Add full access role for development.
    kubectl apply -f hack/develop/developmental-role.yaml

4. Run following to get token for logging into dashboard.
    kubectl -n kubernetes-dashboard create token kubernetes-dashboard

5. Access https://localhost:8443/ with browser on your host,
   then login with token.

@floreks
Copy link
Member

floreks commented Apr 11, 2024

What I meant is that running make serve and make run directly in the dashboard root (without using dev container) dir no longer works with these changes applied.

The development container provides developers with a clean environment at all time.
This creates a environment for static check, test, build and execute dashboard on local machine
that is almost the same as CI/CD environment.
@shu-mutou
Copy link
Contributor Author

@floreks could you check this again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants