Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional printer columns for crd #8583

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Additional printer columns for crd #8583

wants to merge 7 commits into from

Conversation

RafikFarhad
Copy link
Contributor

@RafikFarhad RafikFarhad commented Dec 31, 2023 •
edited

Closes: #7633

Hello,
This is my first PR. Help me find where I need to write tests for this addition.

The CRD objects are shown with additionalPrinterColumns.

image

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 31, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @RafikFarhad!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RafikFarhad
Once this PR has been reviewed and has the lgtm label, please assign maciaszczykm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 31, 2023
@codecov Codecov
Copy link

codecov bot commented Jan 2, 2024 •
edited

Codecov Report

Merging #8583 (f68623c) into master (a2baa5c) will increase coverage by 1.76%.
Report is 109 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8583      +/-   ##
==========================================
+ Coverage   42.22%   43.99%   +1.76%     
==========================================
  Files         219       56     -163     
  Lines       12186     1357   -10829     
  Branches      179      179              
==========================================
- Hits         5146      597    -4549     
+ Misses       6742      709    -6033     
+ Partials      298       51     -247

maciaszczykm
maciaszczykm reviewed Jan 2, 2024
View reviewed changes
Copy link
Member

@maciaszczykm maciaszczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Looks good to me. We would need to test it.

@floreks Any thoughts?

@RafikFarhad
Copy link
Contributor Author

@maciaszczykm I have attempted to write a test, but I am blocked. Can you please suggest some guidelines here?

Jont828
Jont828 reviewed Feb 14, 2024
View reviewed changes
modules/api/pkg/resource/customresourcedefinition/v1/detail_test.go
@@ -0,0 +1,187 @@
// Copyright 2017 The Kubernetes Authors.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2017 The Kubernetes Authors.
// Copyright 2023 The Kubernetes Authors.

modules/api/pkg/resource/customresourcedefinition/types/types.go
Name string `json:"name"`
Type string `json:"type,omitempty"`
Priority int32 `json:"priority,omitempty"`
JSONPath string `json:"jsonPath"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a description field as shown here that can pop up when you hover over the column name?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm left review comments

@Jont828 Jont828 Jont828 left review comments

@shu-mutou shu-mutou Awaiting requested review from shu-mutou

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRD does not show the output like kubectl
4 participants
@RafikFarhad @k8s-ci-robot @maciaszczykm @Jont828