Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Test) Fixed namespace-settings-global setting - added tests #8410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(Test) Fixed namespace-settings-global setting - added tests #8410

wants to merge 1 commit into from

Conversation

romdhanisam
Copy link
Contributor

Navigating out of setting causes an error.

Screenshot 2023-10-21 at 17 40 54

Version v3.0.0-alpha0-233-g7a059ac99

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: romdhanisam
Once this PR has been reviewed and has the lgtm label, please assign shu-mutou for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@romdhanisam romdhanisam marked this pull request as ready for review October 21, 2023 22:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2023
@romdhanisam romdhanisam force-pushed the feat/kd-namespace-settings-test branch 4 times, most recently from 218c8d1 to b04aa1e Compare October 21, 2023 23:56
@romdhanisam romdhanisam force-pushed the feat/kd-namespace-settings-test branch from b04aa1e to 27b3cfa Compare October 22, 2023 14:19
@maciaszczykm maciaszczykm self-assigned this Oct 23, 2023
@romdhanisam
Copy link
Contributor Author

#5623

@romdhanisam
Copy link
Contributor Author

The use of takeUntilDestroyed after upgrading to Angular 16 #8372 shows us that some component are not properly destroyed overall on changing views.

Unit tests can help demonstrate that.

@shu-mutou
Copy link
Contributor

/retest

@shu-mutou
Copy link
Contributor

/test all

@k8s-ci-robot
Copy link
Contributor

@shu-mutou: No presubmit jobs available for kubernetes/dashboard@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks Awaiting requested review from floreks

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm

At least 1 approving review is required to merge this pull request.

Assignees

@maciaszczykm maciaszczykm

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romdhanisam @k8s-ci-robot @shu-mutou @maciaszczykm