Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(angular-material): upgrade to 16 #8345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(angular-material): upgrade to 16 #8345

wants to merge 1 commit into from

Conversation

romdhanisam
Copy link
Contributor

@romdhanisam romdhanisam commented Oct 9, 2023 •
edited

Fixes: #7800

This pull tries to upgrade Angular Material to 16 and fix breaking UI changes from Material Design material.angular.io/guide/mdc-migration

BREAKING CHANGE: ⛵upgrade Angular Material to 16

  1. Changing density for form-field :: density(-4) and icon-button :: density(-3)
  2. Using custom appearance kd-standard-form-field to maintain the natural look of K8S dashboard while the standard form-field appearance is dropped from the Material Design spec v15-mdc-migration.md#form-field
  3. MAT_FORM_FIELD_DEFAULT_OPTIONS experiment to deal with the Angular Material's spec modification.
  4. Another fix: running the MDC migration leaves me with 30 TODO(mdc-migration)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: romdhanisam
Once this PR has been reviewed and has the lgtm label, please assign floreks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 9, 2023
@romdhanisam romdhanisam mentioned this pull request Oct 9, 2023
Closed
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2023
@romdhanisam romdhanisam force-pushed the feat/upgrade-angular-material branch 3 times, most recently from ab497d9 to 443ee7c Compare October 15, 2023 21:34
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 16, 2023
@romdhanisam romdhanisam force-pushed the feat/upgrade-angular-material branch 2 times, most recently from 2e7fad8 to 052e0d2 Compare October 17, 2023 00:12
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 17, 2023
@romdhanisam romdhanisam force-pushed the feat/upgrade-angular-material branch 2 times, most recently from cdfe8a7 to d852523 Compare October 18, 2023 11:12
@romdhanisam romdhanisam marked this pull request as ready for review October 18, 2023 11:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2023
@romdhanisam romdhanisam marked this pull request as draft October 18, 2023 14:35
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2023
@romdhanisam romdhanisam force-pushed the feat/upgrade-angular-material branch 2 times, most recently from 36994ea to 9c87fc9 Compare October 18, 2023 14:38
@romdhanisam romdhanisam marked this pull request as ready for review October 18, 2023 14:39
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2023
@romdhanisam romdhanisam marked this pull request as draft October 20, 2023 21:14
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2023
@romdhanisam romdhanisam marked this pull request as ready for review October 20, 2023 21:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2023
@romdhanisam romdhanisam marked this pull request as draft October 20, 2023 21:28
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2023
@romdhanisam romdhanisam marked this pull request as ready for review October 21, 2023 09:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited

Codecov Report

Merging #8345 (48e7f51) into master (759ab97) will increase coverage by 4.56%.
The diff coverage is n/a.

❗ Current head 48e7f51 differs from pull request most recent head d6d1ceb. Consider uploading reports for the commit d6d1ceb to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8345      +/-   ##
==========================================
+ Coverage   37.51%   42.07%   +4.56%     
==========================================
  Files         255      164      -91     
  Lines       11154    10921     -233     
  Branches      158        0     -158     
==========================================
+ Hits         4184     4595     +411     
+ Misses       6719     6066     -653     
- Partials      251      260       +9

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2024
@romdhanisam romdhanisam force-pushed the feat/upgrade-angular-material branch 2 times, most recently from 6724802 to 48e7f51 Compare January 30, 2024 07:32
@romdhanisam romdhanisam mentioned this pull request Jan 30, 2024
Open
@romdhanisam
Copy link
Contributor Author

@floreks could you trigger the CI workflow?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2024
@romdhanisam
Updates the Angular Material to v16
d6d1ceb 
upgrade angular-material to 16

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): Updates the Angular Material to v15 & Angular CDK to v15

upgrade angular-material to 16

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): Generate mdc-migration

upgrade angular-material to 16
TO FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): Updates the Angular Material to v16 & Angular CDK to v16

upgrade angular-material to 16

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): mat-form-field error fix

upgrade angular-material to 16
TO FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): (mdc-migration) MatChipsModule fix

upgrade angular-material to 16
TO FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): keeping only major change of Angular Material

upgrade angular-material to 16
TO FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): FIX use mat-menu-item directive instead of mat-button in kd-nav components.

upgrade angular-material to 16
TO FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): (mdc-migration) fix [WIP]

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): (mdc-migration) fix form-field-density change [WIP]

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): (mdc-migration) fixes [WIP]

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): (mdc-migration) fixes [WIP] add unique kd-form-field match new mat.form-field-density

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): (mdc-migration) fixes mat card theme & mat-mdc-slider

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): (mdc-migration) fixes ns settings global actions dialogs

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): (mdc-migration) fix mat-tab-group

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): (mdc-migration) fix mat-table

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): (mdc-migration) fix kd-dynamic-cell related actions

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): review TODO(mdc-migration)

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): construct form field appearance standard as deprecated in Material v16, used mat-label instead of placeholder TODO(mdc-migration)

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): use kd-standard-form-field with subscriptSizing fixed in settings local TODO(mdc-migration)

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): fix icon-button-density and use kd-standard-form-field: WIP(mdc-migration)

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): fix secret detail -- code-block-typography, WIP(mdc-migration)

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): fix kd-shell related mdc-migration

upgrade angular-material to 16
FIX: TODO(mdc-migration)

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): fix linting:ts

upgrade angular-material to 16

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): fix linting:html

upgrade angular-material to 16

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): fix linting:scss

upgrade angular-material to 16

BREAKING CHANGE: ⛵upgrade angular-material to 16

feat(angular-material): review kd-theme

upgrade angular-material to 16

BREAKING CHANGE: ⛵upgrade angular-material to 16
@romdhanisam romdhanisam force-pushed the feat/upgrade-angular-material branch from 48e7f51 to d6d1ceb Compare April 1, 2024 22:27
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm

@shu-mutou shu-mutou Awaiting requested review from shu-mutou

@floreks floreks Awaiting requested review from floreks

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support angular/material v16.x.x
2 participants
@romdhanisam @k8s-ci-robot