Set new container image in deployments (former Deployment UI) #7587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7587 +/- ##
==========================================
- Coverage 42.24% 41.92% -0.33%
==========================================
Files 219 217 -2
Lines 12191 12182 -9
Branches 179 179
==========================================
- Hits 5150 5107 -43
- Misses 6743 6790 +47
+ Partials 298 285 -13 |
marcosdiez
force-pushed
the
deployment_ui
branch
from
adf2836
to
1561698
Compare
add deploy button to deployments deploy dialog exists. now it needs to work we now load the containers Deploy UI looks good the UI does almost everything I expect tableData comes reverse sorted small UI changes we can now read the value the dialog returns label change setimage IT WORKS git statusgit status done with the backend cleanup backend: it's now called cansetimage renaming to setimage it's called setimage now, almost everywhere ui looks good now fix replicaset tests fixed all api tests go fmt style change npm run fix
marcosdiez
force-pushed
the
deployment_ui
branch
from
1561698
to
8644d55
Compare
k8s-ci-robot
added
language/de
marcosdiez
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
needs-rebase
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
azro352
suggested changes
Oct 15, 2023
| @@ -986,6 +990,10 @@ | |||
| <source>Last Seen</source> | |||
| <target>Dernière vue</target> | |||
| </trans-unit> | |||
| <trans-unit id="3902185219890107813" datatype="html"> | |||
| <source>Select container...</source> | |||
| <target state="new">Select container...</target> | |||
There was a problem hiding this comment.
Suggested change
| <target state="new">Select container...</target> | |
| <target state="new">Choisissez un conteneur...</target> |
| @@ -102,6 +102,10 @@ | |||
| <source>Every Service Account has a Secret with valid Bearer Token that can be used to log in to Dashboard. To find out more about how to configure and use Bearer Tokens, please refer to the <x id="START_LINK" ctype="x-a" equiv-text=""\uFFFD#2\uFFFD""/>Authentication<x id="CLOSE_LINK" ctype="x-a" equiv-text=""\uFFFD/#2\uFFFD""/> section.</source> | |||
| <target state="new">Chaque compte de service a un Secret associé avec un jeton porteur (Bearer Token) valide qui peut être utilisé pour se connecter au Dashboard. Pour en savoir plus sur la façon de configurer et utiliser des jetons porteurs, veuillez vous référer à la section <x id="START_LINK" ctype="x-a" equiv-text="<a>"/>Authentification<x id="CLOSE_LINK" ctype="x-a" equiv-text="</a>"/>.</target> | |||
| </trans-unit> | |||
| <trans-unit id="1274528669625762639" datatype="html"> | |||
| <source>Set a new container image</source> | |||
| <target state="new">Set a new container image</target> | |||
There was a problem hiding this comment.
Suggested change
| <target state="new">Set a new container image</target> | |
| <target state="new">Définir une nouvelle image de conteneur</target> |
| @@ -1150,6 +1158,10 @@ | |||
| <source>Access modes</source> | |||
| <target>Modes d'accès</target> | |||
| </trans-unit> | |||
| <trans-unit id="4572206383883804416" datatype="html"> | |||
| <source>Set Image</source> | |||
| <target state="new">Set Image</target> | |||
There was a problem hiding this comment.
Suggested change
| <target state="new">Set Image</target> | |
| <target state="new">Définir l'image</target> |
| @@ -1402,6 +1414,10 @@ | |||
| <source>Egress Rules</source> | |||
| <target state="new">Egress Rules</target> | |||
| </trans-unit> | |||
| <trans-unit id="5643209019947694032" datatype="html"> | |||
| <source>container image</source> | |||
| <target state="new">container image</target> | |||
There was a problem hiding this comment.
Suggested change
| <target state="new">container image</target> | |
| <target state="new">image du conteneur</target> |
| @@ -1504,6 +1520,10 @@ | |||
| <source>Exit Code</source> | |||
| <target state="new">Exit Code</target> | |||
| </trans-unit> | |||
| <trans-unit id="5966254721262198145" datatype="html"> | |||
| <source>Previous Image Name (click to use)</source> | |||
| <target state="new">Previous Image Name (click to use)</target> | |||
There was a problem hiding this comment.
Suggested change
| <target state="new">Previous Image Name (click to use)</target> | |
| <target state="new">Nom de l'image précédente (cliquer pour utiliser)</target> |
| @@ -1964,6 +1992,10 @@ | |||
| <source>NAMESPACES</source> | |||
| <target>ESPACES DE NOMS</target> | |||
| </trans-unit> | |||
| <trans-unit id="7574968363077451152" datatype="html"> | |||
| <source>Previous Deployment Date</source> | |||
| <target state="new">Previous Deployment Date</target> | |||
There was a problem hiding this comment.
Suggested change
| <target state="new">Previous Deployment Date</target> | |
| <target state="new">Date du déploiement précédent</target> |
| @@ -1884,6 +1908,10 @@ | |||
| <source>Init Containers</source> | |||
| <target>Conteneurs d'initilisation</target> | |||
| </trans-unit> | |||
| <trans-unit id="7286769344436324609" datatype="html"> | |||
| <source>Set Container Image</source> | |||
| <target state="new">Set Container Image</target> | |||
There was a problem hiding this comment.
Suggested change
| <target state="new">Set Container Image</target> | |
| <target state="new">Définir l'image d'un conteneur</target> |
| @@ -1600,6 +1620,10 @@ | |||
| <source>TCP Socket</source> | |||
| <target state="new">TCP Socket</target> | |||
| </trans-unit> | |||
| <trans-unit id="6406804063343897494" datatype="html"> | |||
| <source>A container image will be replaced on <x id="INTERPOLATION" equiv-text=""\uFFFD0\uFFFD""/> <x id="INTERPOLATION_1" equiv-text=""\uFFFD1\uFFFD""/>.</source> | |||
| <target state="new">A container image will be replaced on <x id="INTERPOLATION" equiv-text=""\uFFFD0\uFFFD""/> <x id="INTERPOLATION_1" equiv-text=""\uFFFD1\uFFFD""/>.</target> | |||
There was a problem hiding this comment.
Suggested change
| <target state="new">A container image will be replaced on <x id="INTERPOLATION" equiv-text=""\uFFFD0\uFFFD""/> <x id="INTERPOLATION_1" equiv-text=""\uFFFD1\uFFFD""/>.</target> | |
| <target state="new">L'image d'un conteneur sera remplacée sur le <x id="INTERPOLATION" equiv-text=""\uFFFD0\uFFFD""/> <x id="INTERPOLATION_1" equiv-text=""\uFFFD1\uFFFD""/>.</target> |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marcosdiez The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
lifecycle/stale
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
|
@maciaszczykm hi. could we merge my PR sometime this year ? |
marcosdiez
force-pushed
the
deployment_ui
branch
from
03cc778
to
d6cd718
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7576
For this to work, I had to an unexpected API verb:
apiV1Ws.GET("/deployment/{namespace}/{deployment}/allreplicasets"), which lists all replica sets from a deployment so we can show the previous deployment imagesAlso, on the replicasets, I had to add a two new maps called:
their key is the container name, their value is the container image, again, so I can list them.
That does add redundancy, for currently all objects have two lists: ContainerNames and InitContainerNames that don't have the container names.
Should I open a separate PR to refactor so that we just use ContainerNames and InitContainerNames but as maps instead of lists ?
On the new Set Image dialog, maybe we should have link with the image image instead of buttons ?
I explicitly ignrored init container images, because since they can have the same name as container images, I though that would clutter the UI.
Also, I could have made a table instead of changing one image at a time, but I can't see any real use case for that.
Suggestions are welcome
This PR can be tested using the following containers: