Resource owner now shown in every pane #7489

marcosdiez · 2022-09-29T14:17:43Z

This is a duplicate of #6237

I am not sure if this is useful anywhere but in a ReplicaSet and in a Job started by a CronJob Also, we have the "problem" of having the info shown twice in Pods.

@floreks , my team and I use this every day. It's quite useful. Consider merging, please!

This PR can be tested using the following containers:

marcosdiez/dashboard-api:v2.7.0.b
marcosdiez/dashboard-web:v2.7.0.b

k8s-ci-robot · 2022-09-29T14:17:49Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marcosdiez
Once this PR has been reviewed and has the lgtm label, please assign shu-mutou for approval by writing /assign @shu-mutou in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

maciaszczykm · 2022-09-30T09:59:49Z

@marcosdiez CI doesn't pass.

What do you mean by duplicate?

codecov · 2022-09-30T11:43:14Z

Codecov Report

Merging #7489 (95a06ec) into master (6e3ef1f) will decrease coverage by 0.16%.
Report is 726 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7489      +/-   ##
==========================================
- Coverage   42.10%   41.94%   -0.16%     
==========================================
  Files         217      163      -54     
  Lines       12084    10845    -1239     
  Branches      179        0     -179     
==========================================
- Hits         5088     4549     -539     
+ Misses       6711     6049     -662     
+ Partials      285      247      -38

marcosdiez · 2022-09-30T12:21:21Z

Hi @maciaszczykm

I'll get all the tests passed soon. Sorry for the inconvenient.

marcosdiez · 2022-10-09T06:38:20Z

@floreks @maciaszczykm do you guys know why the tests are failing ?
the quick way to reproduce it is to type yarn test src/resource/discovery/ingress/detail/component.spec.ts

The issue is caused by this line:

dashboard/modules/web/src/resource/discovery/ingress/detail/component.spec.ts

Line 167 in 95a06ec

ObjectMetaComponent,

The part that the above line has an issue with is this one:

https://github.com/marcosdiez/dashboard/blob/704c1e10b4e499e5dd9fa6e14f59bf0026ea826c/modules/web/src/common/components/objectmeta/component.ts#L29

but I am having trouble understanding why. Suggestions are welcome. Thank you!

maciaszczykm · 2022-10-28T10:04:01Z

modules/web/src/common/components/objectmeta/component.ts

@@ -23,6 +26,8 @@ export class ObjectMetaComponent {
  @Input() initialized = false;

  private objectMeta_: ObjectMeta;
+  private readonly kdState_: KdStateService = GlobalServicesModule.injector.get(KdStateService);


Why not using constructor for that?

^ @marcosdiez

@maciaszczykm I tried

private readonly kdState_: KdStateService; constructor() { this.kdState_ = GlobalServicesModule.injector.get(KdStateService); }

and it fails just like without the constructor.

mdiez@batman:~/code/dashboard/modules/web$ yarn test src/resource/discovery/ingress/detail/component.spec.ts FAIL src/resource/discovery/ingress/detail/component.spec.ts ● Test suite failed to run src/common/services/pluginloader/clientloader.service.ts:21:25 - error TS2339: Property 'System' does not exist on type 'Window & typeof globalThis'. 21 const systemJS = window.System; ~~~~~~ src/common/services/pluginloader/clientloader.service.ts:31:14 - error TS2339: Property 'define' does not exist on type 'Window & typeof globalThis'. 31 window.define(externalKey, [], () => { ~~~~~~ src/common/services/pluginloader/clientloader.service.ts:51:52 - error TS7006: Parameter 'm' implicitly has an 'any' type. 51 return systemJS.import(dependency.path).then(m => { ~ src/common/services/pluginloader/clientloader.service.ts:52:16 - error TS7015: Element implicitly has an 'any' type because index expression is not of type 'number'. 52 window['define'](dep, [], () => m.default); ~~~~~~~~ src/common/services/pluginloader/clientloader.service.ts:57:48 - error TS7006: Parameter 'module' implicitly has an 'any' type. 57 return systemJS.import(plugin.path).then(module => module.default.default); ~~~~~~ Test Suites: 1 failed, 1 total

I am out of ideas. I'll try again next week.

@marcosdiez I mean like here:

https://github.com/kubernetes/dashboard/blob/master/modules/web/src/common/components/actionbar/detailactions/exec/component.ts#L26

@maciaszczykm it did not work either :(

@maciaszczykm I still need help here ....

@marcosdiez Sorry, I do not have time this and perhaps next month to work on the project. Once I will find some I will take a look on it.

marcosdiez · 2023-07-06T22:38:20Z

/remove-lifecycle stale

azro352 · 2023-10-15T09:51:47Z

modules/web/i18n/fr/messages.fr.xlf

@@ -930,6 +930,10 @@
        <source>unset</source>
        <target>non défini</target>
      </trans-unit>
+      <trans-unit id="3715596725146409911" datatype="html">
+        <source>Owner</source>
+        <target state="new">Owner</target>


Suggested change

<target state="new">Owner</target>

<target state="new">Propriétaire</target>

k8s-triage-robot · 2024-01-22T10:27:48Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

marcosdiez · 2024-01-22T11:09:49Z

/remove-lifecycle stale

marcosdiez · 2024-01-22T11:10:35Z

/remove-lifecycle stale

marcosdiez · 2024-01-22T11:14:11Z

@maciaszczykm hi. could we merge my PR sometime this year ?

k8s-ci-robot · 2024-03-27T17:35:33Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot requested review from floreks and maciaszczykm September 29, 2022 14:17

marcosdiez force-pushed the resource_owner_v2 branch from 68e9ebb to 808864b Compare September 30, 2022 11:31

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2022

marcosdiez force-pushed the resource_owner_v2 branch from 808864b to 2d138e0 Compare September 30, 2022 11:39

marcosdiez added 2 commits October 9, 2022 02:15

resource owner

704c1e1

i18n

95a06ec

marcosdiez force-pushed the resource_owner_v2 branch from 2d138e0 to 95a06ec Compare October 9, 2022 05:19

maciaszczykm reviewed Oct 28, 2022

View reviewed changes

maciaszczykm self-assigned this Jan 17, 2023

maciaszczykm assigned maciaszczykm and unassigned maciaszczykm Apr 14, 2023

maciaszczykm removed their assignment Jun 2, 2023

azro352 reviewed Oct 15, 2023

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resource owner now shown in every pane #7489

Resource owner now shown in every pane #7489

marcosdiez commented Sep 29, 2022 •

edited

k8s-ci-robot commented Sep 29, 2022

maciaszczykm commented Sep 30, 2022

codecov bot commented Sep 30, 2022 •

edited

marcosdiez commented Sep 30, 2022

marcosdiez commented Oct 9, 2022 •

edited

maciaszczykm Oct 28, 2022

maciaszczykm Dec 2, 2022

marcosdiez Dec 6, 2022

maciaszczykm Dec 9, 2022

marcosdiez Dec 26, 2022

marcosdiez Jan 13, 2023

maciaszczykm Jan 17, 2023

marcosdiez commented Jul 6, 2023

azro352 Oct 15, 2023

k8s-triage-robot commented Jan 22, 2024

marcosdiez commented Jan 22, 2024

marcosdiez commented Jan 22, 2024

marcosdiez commented Jan 22, 2024

k8s-ci-robot commented Mar 27, 2024

	<target state="new">Owner</target>
	<target state="new">Propriétaire</target>

Resource owner now shown in every pane #7489

Are you sure you want to change the base?

Resource owner now shown in every pane #7489

Conversation

marcosdiez commented Sep 29, 2022 • edited

k8s-ci-robot commented Sep 29, 2022

maciaszczykm commented Sep 30, 2022

codecov bot commented Sep 30, 2022 • edited

Codecov Report

marcosdiez commented Sep 30, 2022

marcosdiez commented Oct 9, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcosdiez commented Jul 6, 2023

Choose a reason for hiding this comment

k8s-triage-robot commented Jan 22, 2024

marcosdiez commented Jan 22, 2024

marcosdiez commented Jan 22, 2024

marcosdiez commented Jan 22, 2024

k8s-ci-robot commented Mar 27, 2024

marcosdiez commented Sep 29, 2022 •

edited

codecov bot commented Sep 30, 2022 •

edited

marcosdiez commented Oct 9, 2022 •

edited