Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated OWNERS file to include link to docs #3547

Merged
merged 1 commit into from Feb 6, 2019

Conversation

rlenferink
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2019
@rlenferink
Copy link
Member Author

/assign @jeefy

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #3547 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3547   +/-   ##
=======================================
  Coverage   48.31%   48.31%           
=======================================
  Files         165      165           
  Lines        8026     8026           
  Branches       43       43           
=======================================
  Hits         3878     3878           
  Misses       3866     3866           
  Partials      282      282

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43c9568...61924ae. Read the comment docs.

@floreks
Copy link
Member

floreks commented Feb 5, 2019

I don't see such comment at i.e. kubernetes repo OWNERS file. Why do we need it?

@rlenferink
Copy link
Member Author

I'm still working through the repos to get them included:
kubernetes-sigs/cluster-api#729
kubernetes/cloud-provider-gcp#81
kubernetes-client/go#20
kubernetes/utils#79
kubernetes/test-infra#11044
kubernetes/community#3172
kubernetes/org#435

A PR with k/k is still open and needs some fine-tuning before getting merged:
kubernetes/kubernetes#73540

It is not necessarily a thing we require to have. It is more of a convenience link for contributors looking for the documentation of our processes.

@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, rlenferink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1f2007d into kubernetes:master Feb 6, 2019
@rlenferink rlenferink deleted the patch-owners branch February 6, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants