feat: add support for parameters for storageClass #2434

sakshi-1505 · 2023-10-15T14:09:00Z

fixes #1980

- adds support for parameter in storageClass for csi_chart

k8s-ci-robot · 2023-10-15T14:09:07Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dulek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2023-10-15T14:09:10Z

Hi @sakshi-1505. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sakshi-1505 · 2023-10-15T14:13:35Z

@zetaab @pierreprinetti @jichenjc Please take a look.

jichenjc · 2023-10-16T02:13:35Z

charts/cinder-csi-plugin/values.yaml

@@ -160,6 +160,12 @@ secret:

 storageClass:
  enabled: true
+  parameters:


is this sample ? so should be comment out?

I don't really believe commenting our things in helm's values but always like to put each & every change behind a toggle to maintain backward compatibility. It's not a sample but actual values file, & I have kept all changed behind the storageClass.parameters.Enabled toggle, so this is a backward compatible change where folks if want can enable & by default it won't take effect.

jichenjc · 2023-10-17T08:23:13Z

charts/cinder-csi-plugin/values.yaml

+  parameters:
+    enabled: false
+    type: gp2
+    availabilityZone: us-east-1a


I am talking about here, e.g apparently we don't want any chart default to this AWS region?

I got your point, let me fix this real quick

Signed-off-by: sakshi-1505 <sakshipatle.0808cs171134@gmail.com>

sakshi-1505 · 2023-10-17T14:30:33Z

Please check again @jichenjc

jichenjc · 2023-10-19T03:06:47Z

/ok-to-test

sakshi-1505 · 2023-10-22T16:17:41Z

@jichenjc @pierreprinetti can I please get a review here?

jichenjc · 2023-10-24T02:54:43Z

/lgtm

dulek · 2023-10-25T11:21:06Z

charts/cinder-csi-plugin/templates/storageclass.yaml

+  availabilityZone: {{ .Values.storageClass.parameters.availabilityZone }}
+  {{ end }}
+  {{ range .Values.storageClass.parameters.additionalParameters }}
+  {{ .key }}: {{ .value }}


Are you sure this will be properly indented? Could we do it like here instead?

cloud-provider-openstack/charts/manila-csi-plugin/templates/nodeplugin-daemonset.yaml

Lines 120 to 123 in 2565d89

{{- with .Values.nodeplugin.hostAliases }}

hostAliases:

{{- toYaml . | nindent 8 }}

{{- end }}

@sakshi-1505: Seems like you've missed this one comment.

dulek · 2023-10-25T11:23:12Z

Oh, you're missing the release note box too. Grab it from the template:

cloud-provider-openstack/.github/PULL_REQUEST_TEMPLATE.md

Lines 31 to 33 in 66624e3

    
           ```release-note 
        
           NONE 
        
           ```

sakshi-1505 · 2023-10-28T14:42:33Z

@dulek please recheck

dulek

Can you check one of my previous comments?

Besides that let's improve the release note a bit. How about:

[cinder-csi-plugin] Added support for modifying StorageClass parameters in the Helm chart.

dulek · 2023-10-30T17:46:55Z

charts/cinder-csi-plugin/templates/storageclass.yaml

+  availabilityZone: {{ .Values.storageClass.parameters.availabilityZone }}
+  {{ end }}
+  {{ range .Values.storageClass.parameters.additionalParameters }}
+  {{ .key }}: {{ .value }}


@sakshi-1505: Seems like you've missed this one comment.

k8s-ci-robot · 2023-12-29T00:38:09Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2024-03-28T00:40:00Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-04-27T01:32:45Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-05-27T01:39:19Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-05-27T01:39:24Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 15, 2023

k8s-ci-robot requested review from dulek and zetaab October 15, 2023 14:09

sakshi-1505 changed the title ~~feat: add support for parametes for storageClass~~ feat: add support for parameters for storageClass Oct 15, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 15, 2023

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 15, 2023

jichenjc reviewed Oct 16, 2023

View reviewed changes

sakshi-1505 requested a review from jichenjc October 16, 2023 10:11

jichenjc reviewed Oct 17, 2023

View reviewed changes

feat: add support for parametes for storageClass

06f9751

Signed-off-by: sakshi-1505 <sakshipatle.0808cs171134@gmail.com>

sakshi-1505 force-pushed the support_parameters_csi_cahrt branch from c892c4e to 06f9751 Compare October 17, 2023 14:30

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 19, 2023

k8s-ci-robot assigned jichenjc Oct 24, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023

dulek requested changes Oct 25, 2023

View reviewed changes

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 28, 2023

dulek requested changes Oct 30, 2023

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 29, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 28, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 27, 2024

k8s-ci-robot closed this May 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for parameters for storageClass #2434

feat: add support for parameters for storageClass #2434

sakshi-1505 commented Oct 15, 2023 •

edited

k8s-ci-robot commented Oct 15, 2023

k8s-ci-robot commented Oct 15, 2023

sakshi-1505 commented Oct 15, 2023

jichenjc Oct 16, 2023

sakshi-1505 Oct 16, 2023

jichenjc Oct 17, 2023

sakshi-1505 Oct 17, 2023

sakshi-1505 commented Oct 17, 2023

jichenjc commented Oct 19, 2023

sakshi-1505 commented Oct 22, 2023

jichenjc commented Oct 24, 2023

dulek Oct 25, 2023

dulek Oct 30, 2023

dulek commented Oct 25, 2023

sakshi-1505 commented Oct 28, 2023

dulek left a comment

dulek Oct 30, 2023

k8s-ci-robot commented Dec 29, 2023

k8s-triage-robot commented Mar 28, 2024

k8s-triage-robot commented Apr 27, 2024

k8s-triage-robot commented May 27, 2024

k8s-ci-robot commented May 27, 2024

	{{- with .Values.nodeplugin.hostAliases }}
	hostAliases:
	{{- toYaml . \| nindent 8 }}
	{{- end }}

feat: add support for parameters for storageClass #2434

feat: add support for parameters for storageClass #2434

Conversation

sakshi-1505 commented Oct 15, 2023 • edited

k8s-ci-robot commented Oct 15, 2023

k8s-ci-robot commented Oct 15, 2023

sakshi-1505 commented Oct 15, 2023

jichenjc Oct 16, 2023

Choose a reason for hiding this comment

sakshi-1505 Oct 16, 2023

Choose a reason for hiding this comment

jichenjc Oct 17, 2023

Choose a reason for hiding this comment

sakshi-1505 Oct 17, 2023

Choose a reason for hiding this comment

sakshi-1505 commented Oct 17, 2023

jichenjc commented Oct 19, 2023

sakshi-1505 commented Oct 22, 2023

jichenjc commented Oct 24, 2023

dulek Oct 25, 2023

Choose a reason for hiding this comment

dulek Oct 30, 2023

Choose a reason for hiding this comment

dulek commented Oct 25, 2023

sakshi-1505 commented Oct 28, 2023

dulek left a comment

Choose a reason for hiding this comment

dulek Oct 30, 2023

Choose a reason for hiding this comment

k8s-ci-robot commented Dec 29, 2023

k8s-triage-robot commented Mar 28, 2024

k8s-triage-robot commented Apr 27, 2024

k8s-triage-robot commented May 27, 2024

k8s-ci-robot commented May 27, 2024

sakshi-1505 commented Oct 15, 2023 •

edited