-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update various k8s.io modules to v0.22.0 #263
Conversation
Hi @sdmodi. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sdmodi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
go.mod
Outdated
@@ -80,7 +70,7 @@ replace ( | |||
k8s.io/apiserver => k8s.io/apiserver v0.21.0 | |||
k8s.io/cli-runtime => k8s.io/cli-runtime v0.21.0 | |||
k8s.io/client-go => k8s.io/client-go v0.21.0 | |||
k8s.io/cloud-provider => k8s.io/cloud-provider v0.21.0 | |||
k8s.io/cloud-provider => k8s.io/cloud-provider v0.22.0 | |||
k8s.io/cloud-provider-gcp/providers => ./providers | |||
k8s.io/cluster-bootstrap => k8s.io/cluster-bootstrap v0.21.0 | |||
k8s.io/code-generator => k8s.io/code-generator v0.21.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the k8s v0.21.0
modules should be upgraded to v0.22.0
at the same time.
go.mod
Outdated
k8s.io/klog/v2 v2.8.0 | ||
k8s.io/component-base v0.22.0 | ||
k8s.io/controller-manager v0.22.0 | ||
k8s.io/klog/v2 v2.9.0 | ||
k8s.io/kubelet v0.21.0 | ||
k8s.io/kubernetes v1.21.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the k8s v0.21.0
modules should be upgraded to v0.22.0
at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I update k8s.io/kubernetes v1.21.0 to v1.22.0, I see this:
go: k8s.io/kubernetes@v1.22.0 requires
k8s.io/pod-security-admission@v0.0.0: reading k8s.io/pod-security-admission/go.mod at revision v0.0.0: unknown revision v0.0.0
How should I resolve this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you should add k8s.io/pod-security-admission => k8s.io/pod-security-admission v0.22.0
in the replace
section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this: openshift#2 It seems working.
I made progress on this and I am unable to commit the changes. Here is the message I see:
This looks like a false positive because the git config for allowed secrets is this:
The last pattern should have allowed the access token. I committed the code using 'git commit -a --no-verify' |
Joe/Minhan, would you please review this. I think it also requires the ok-to-test label. Thanks! |
/ok-to-test |
I would recommend breaking this into 2 commits. One with the go mod changes. The other one with auto generated changes. |
Split this up into 2 commits. |
Looks like the build is failing for the following reason:
|
I updated google.golang.org/grpc to v1.32.0 and that got rid of the original error. Now I am seeing a new one:
|
This is another error for the e2e-full tests:
|
you can pass nil for the new arg |
it seems likely you'll need to bump to a version newer than 0.22.0 to pick up a compatible version of k8s.io/legacy-cloud-providers that can work with the updated google api library |
@sdmodi: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Updating legacy-cloud-providers runs into another problem:
What is our usual process for updating k8s.io modules? Is it common to keep running into these issues? Are there a set of modules that we always update in one go. |
It could be cause by inconsistent of dependency version. k/k is using |
I have combined this patch with #262 as both need to be updated at the same time for tests to pass. |
This was done by modifying the version of k8s.io/cloud-provider in go.mod and providers/go.mod to v0.22.0 and running ./tools/update_vendor.sh.
This change pulls in kubernetes/kubernetes#103951 which is required for correct bringup of the nodeipam controller in cloud-controller-manager.