Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move static scheduler initialization out of module init() #2056

Merged

Conversation

losipiuk
Copy link
Contributor

Having call to algorithmprovider.ApplyFeatureGates() in module init
function was problematic as the mathod calls out to klog.Infof().
The call to klog.Infof() was then happening before klog related
application flags were parsed which resulted in klog misbehavior.
See kubernetes/klog#67.

Having call to algorithmprovider.ApplyFeatureGates() in module init
function was problematic as the mathod calls out to klog.Infof().
The call to klog.Infof() was then happening before klog related
application flags were parsed which resulted in klog misbehavior.
See kubernetes/klog#67.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2019
@losipiuk
Copy link
Contributor Author

/assign @Maci

@k8s-ci-robot
Copy link
Contributor

@losipiuk: GitHub didn't allow me to assign the following users: maci.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Maci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 22, 2019
@losipiuk
Copy link
Contributor Author

/assign @MaciekPytel

@MaciekPytel
Copy link
Contributor

/lgtm
/approve

Nice job finding this.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5c743c1 into kubernetes:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants