Skip to content

Commit

Permalink
enhance and fix log calls
Browse files Browse the repository at this point in the history
Some of these changes are cosmetic (repeatedly calling klog.V instead of
reusing the result), others address real issues:

- Logging a message only above a certain verbosity threshold without
  recording that verbosity level (if klog.V().Enabled() { klog.Info... }):
  this matters when using a logging backend which records the verbosity
  level.

- Passing a format string with parameters to a logging function that
  doesn't do string formatting.

All of these locations where found by the enhanced logcheck tool from
kubernetes/klog#297.

In some cases it reports false positives, but those can be suppressed with
source code comments.

Partial cherry-pick of edffc700a43e610f641907290a5152ca593bad79

Kubernetes-commit: 4da1f79f991f52f69dbb9d567bdd4f5e1d7b0b24
  • Loading branch information
pohly authored and k8s-publishing-bot committed Dec 17, 2022
1 parent eca9d97 commit 43c48b2
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pkg/registry/generic/registry/storage_factory.go
Expand Up @@ -50,6 +50,7 @@ func StorageWithCacher() generic.StorageDecorator {
return s, d, err
}
if klog.V(5).Enabled() {
//nolint:logcheck // It complains about the key/value pairs because it cannot check them.
klog.InfoS("Storage caching is enabled", objectTypeToArgs(newFunc())...)
}

Expand Down

0 comments on commit 43c48b2

Please sign in to comment.